Skip to content

Test external rust bindings build with additional libcryptos #5248

Open
@goatgoose

Description

@goatgoose

Problem:

#5229 added unit test coverage for the external build Rust bindings feature by building s2n-tls externally with AWS-LC. However, it's possible for s2n-tls to be built with an arbitrary libcrypto and provided to the Rust bindings with the external build feature, which there isn't currently test coverage for.

Solution:

We should test the external build feature with additional libcryptos, minimally OpenSSL 1.1.1.

In implementing #5229, it was discovered that some unit tests assume that AWS-LC is the linked libcrypto:

pair.handshake().unwrap();
assert_eq!(pair.client.kem_group_name(), Some("X25519MLKEM768"));

These tests should be updated to avoid this assumption.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions