Skip to content

Commit 03d855b

Browse files
authored
Fix missing put metrics (#341)
1 parent e61bb50 commit 03d855b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/pr-checks.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
108108

109109
steps:
110-
- uses: actions/checkout@v3
110+
- uses: actions/checkout@v4
111111
with:
112112
ref: ${{ github.event.pull_request.head.sha }}
113113
- name: Set up Python ${{ matrix.python-version }}
@@ -183,7 +183,7 @@ jobs:
183183
- name: Execute Python Coverage compute script and capture output
184184
id: execute_coverage_parse_script
185185
run: |
186-
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }}* ]]; then
186+
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
187187
aws cloudwatch put-metric-data --metric-name UnitTestCoverage --namespace SageMakerPySdkCoreMonitoringMetrics --value $(python workflow_helper/compute_resource_coverage.py) --unit Count --dimensions MetricCategory=Unit-${{ matrix.python-version }}
188188
else
189189
echo "Putting metrics has been skipped"
@@ -208,7 +208,7 @@ jobs:
208208
role-duration-seconds: 10800
209209
- name: Execute Boto API Coverage compute script and capture output
210210
run: |
211-
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }}* ]]; then
211+
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
212212
output=$(python workflow_helper/compute_boto_api_coverage.py)
213213
unsupported_apis=$(echo $output | cut -d ' ' -f1)
214214
supported_apis=$(echo $output | cut -d ' ' -f2)
@@ -221,7 +221,7 @@ jobs:
221221
runs-on: ubuntu-latest
222222
needs: [wait-for-approval]
223223
steps:
224-
- uses: actions/checkout@v3
224+
- uses: actions/checkout@v4
225225
with:
226226
ref: ${{ github.event.pull_request.head.sha }}
227227
- name: Set up Python

0 commit comments

Comments
 (0)