Skip to content

Commit 3de4b27

Browse files
committed
Remove deprecated ioutil calls
Signed-off-by: Micah Hausler <[email protected]>
1 parent e9d3aca commit 3de4b27

File tree

3 files changed

+9
-27
lines changed

3 files changed

+9
-27
lines changed

provider/secrets_manager_provider.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package provider
33
import (
44
"context"
55
"fmt"
6-
"io/ioutil"
6+
"os"
77

88
"github.com/aws/aws-sdk-go/aws"
99
"github.com/aws/aws-sdk-go/aws/session"
@@ -246,7 +246,7 @@ func (p *SecretsManagerProvider) fetchSecret(
246246
// Reads a secret back in from the file system.
247247
func (p *SecretsManagerProvider) reloadSecret(descriptor *SecretDescriptor) (val *SecretValue, e error) {
248248

249-
sValue, err := ioutil.ReadFile(descriptor.GetMountPath())
249+
sValue, err := os.ReadFile(descriptor.GetMountPath())
250250
if err != nil {
251251
return nil, err
252252
}

server/server.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"context"
1212
"encoding/json"
1313
"fmt"
14-
"io/ioutil"
1514
"os"
1615
"strconv"
1716
"strings"
@@ -303,7 +302,7 @@ func (s *CSIDriverProviderServer) writeFile(secret *provider.SecretValue, mode o
303302
}
304303

305304
// Write to a tempfile first
306-
tmpFile, err := ioutil.TempFile(secret.Descriptor.GetMountDir(), secret.Descriptor.GetFileName())
305+
tmpFile, err := os.CreateTemp(secret.Descriptor.GetMountDir(), secret.Descriptor.GetFileName())
307306
if err != nil {
308307
return nil, err
309308
}

server/server_test.go

+6-23
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
"io/ioutil"
87
"os"
98
"path/filepath"
109
"regexp"
@@ -297,7 +296,7 @@ func validateMounts(t *testing.T, dir string, tst testCase, rsp *v1alpha1.MountR
297296

298297
// Check for the expected secrets
299298
for file, val := range tst.expSecrets {
300-
secretVal, err := ioutil.ReadFile(filepath.Join(dir, file))
299+
secretVal, err := os.ReadFile(filepath.Join(dir, file))
301300
if err != nil {
302301
t.Errorf("%s: Can not read file %s", tst.testName, file)
303302
return false
@@ -349,7 +348,7 @@ func validateResponse(t *testing.T, dir string, tst testCase, rsp *v1alpha1.Moun
349348
t.Errorf("%s: could not create base directory: %v", tst.testName, err)
350349
return false
351350
}
352-
if err := ioutil.WriteFile(fullPath, secretVal, os.FileMode(perm)); err != nil {
351+
if err := os.WriteFile(fullPath, secretVal, os.FileMode(perm)); err != nil {
353352
t.Errorf("%s: could not write secret: %v", tst.testName, err)
354353
return false
355354
}
@@ -1994,11 +1993,7 @@ func TestMounts(t *testing.T) {
19941993

19951994
t.Run(tst.testName, func(t *testing.T) {
19961995

1997-
dir, err := ioutil.TempDir("", strings.Map(nameMapper, tst.testName))
1998-
if err != nil {
1999-
panic(err)
2000-
}
2001-
defer os.RemoveAll(dir) // Cleanup
1996+
dir := t.TempDir() // t.TempDir() handles cleanup automatically
20021997

20031998
svr := newServerWithMocks(&tst, false)
20041999

@@ -2035,11 +2030,7 @@ func TestMountsNoWrite(t *testing.T) {
20352030

20362031
t.Run(tst.testName, func(t *testing.T) {
20372032

2038-
dir, err := ioutil.TempDir("", strings.Map(nameMapper, tst.testName))
2039-
if err != nil {
2040-
panic(err)
2041-
}
2042-
defer os.RemoveAll(dir) // Cleanup
2033+
dir := t.TempDir() // t.TempDir() handles cleanup automatically
20432034

20442035
svr := newServerWithMocks(&tst, true)
20452036

@@ -2452,11 +2443,7 @@ var remountTests []testCase = []testCase{
24522443
// Validate rotation
24532444
func TestReMounts(t *testing.T) {
24542445

2455-
dir, err := ioutil.TempDir("", "TestReMounts")
2456-
if err != nil {
2457-
panic(err)
2458-
}
2459-
defer os.RemoveAll(dir) // Cleanup
2446+
dir := t.TempDir() // t.TempDir() handles cleanup automatically
24602447

24612448
curState := []*v1alpha1.ObjectVersion{}
24622449

@@ -2494,11 +2481,7 @@ func TestReMounts(t *testing.T) {
24942481
// Validate rotation
24952482
func TestNoWriteReMounts(t *testing.T) {
24962483

2497-
dir, err := ioutil.TempDir("", "TestReMounts")
2498-
if err != nil {
2499-
panic(err)
2500-
}
2501-
defer os.RemoveAll(dir) // Cleanup
2484+
dir := t.TempDir() // t.TempDir() handles cleanup automatically
25022485

25032486
curState := []*v1alpha1.ObjectVersion{}
25042487

0 commit comments

Comments
 (0)