-
Notifications
You must be signed in to change notification settings - Fork 87
Description
Hi Folks,
What guidelines and expectations do you have to keep this codebase following community best practices around CI/CD, using a recent version of golang, dependency updates, and Issue/PR resolution?
A few things that give me pause about having high confidence in this tooling:
- Lack of visible CI/CD
- Pulling project and running unit tests fails. I would rely on CI here but I don't see any, so I pulled mainline (non-standard branch naming) and tried to run tests. To find this doesn't use go modules, then coerced the project to use go modules and find the tests fail for 11 cases.
- Long standing unaddressed issues. In the following categories: unanswered and unfixed and unmerged.
Since this is a project recommended by AWS for performing SSM operations, I expect it to be in better standing for these standard practices: visible CI, passing unit tests, generally groomed set of Issues/PRs (even if some cannot be fixed they can be discussed and decided on the right path forward).
If those things are not tenable given AWS team priorities, can you please document this prominently on the README? Since I understand some aspects of AWS methodology, I'll also file a request with our account manager to help back this request.