add missing waiter retry breakout on non-nil non-matched error (#561)

lucix-aws · web-flow · commit 5e16ee7648a8 · 2025-01-09T15:49:28.000-05:00
diff --git a/codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Waiters.java b/codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Waiters.java
@@ -670,6 +670,7 @@ private void generateRetryable(
                     });
 
                     writer.write("");
+                    writer.write("if err != nil { return false, err }");
                     writer.write("return true, nil");
                 });
     }
diff --git a/codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Waiters2.java b/codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/integration/Waiters2.java
@@ -649,6 +649,7 @@ private void generateRetryable(
                     });
 
                     writer.write("");
+                    writer.write("if err != nil { return false, err }");
                     writer.write("return true, nil");
                 });
     }

Original file line number	Diff line number	Diff line change
`@@ -670,6 +670,7 @@ private void generateRetryable(`
`670`	`670`	`});`
`671`	`671`
`672`	`672`	`writer.write("");`
	`673`	`+ writer.write("if err != nil { return false, err }");`
`673`	`674`	`writer.write("return true, nil");`
`674`	`675`	`});`
`675`	`676`	`}`
Original file line number	Diff line number	Diff line change
`@@ -649,6 +649,7 @@ private void generateRetryable(`
`649`	`649`	`});`
`650`	`650`
`651`	`651`	`writer.write("");`
	`652`	`+ writer.write("if err != nil { return false, err }");`
`652`	`653`	`writer.write("return true, nil");`
`653`	`654`	`});`
`654`	`655`	`}`