Skip to content

Commit b17b844

Browse files
authored
Run vet and unit-race tests on GH runner instead of plain test (#575)
1 parent 89ba6cf commit b17b844

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

.github/workflows/go.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ jobs:
2323
go-version: ${{ matrix.go-version }}
2424

2525
- name: Test
26-
run: go test -v ./...
26+
run: make unit-race

Makefile

-2
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,10 @@ cover:
6969
.PHONY: unit unit-race unit-test unit-race-test
7070

7171
unit: verify
72-
go vet ${BUILD_TAGS} --all ./... && \
7372
go test ${BUILD_TAGS} ${RUN_NONE} ./... && \
7473
go test -timeout=1m ${UNIT_TEST_TAGS} ./...
7574

7675
unit-race: verify
77-
go vet ${BUILD_TAGS} --all ./... && \
7876
go test ${BUILD_TAGS} ${RUN_NONE} ./... && \
7977
go test -timeout=1m ${UNIT_TEST_TAGS} -race -cpu=4 ./...
8078

document/cbor/decode.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func (d *decoder) Decode(v cbor.Value, to interface{}) error {
4848

4949
rv := reflect.ValueOf(to)
5050
if rv.Kind() != reflect.Ptr || rv.IsNil() || !rv.IsValid() {
51-
return &document.InvalidUnmarshalError{reflect.TypeOf(to)}
51+
return &document.InvalidUnmarshalError{Type: reflect.TypeOf(to)}
5252
}
5353

5454
return d.decode(v, rv, serde.Tag{})

document/cbor/encode.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ func (e *encoder) encodeMap(rv reflect.Value) (cbor.Map, error) {
145145
for _, key := range rv.MapKeys() {
146146
keyName := fmt.Sprint(key.Interface())
147147
if keyName == "" {
148-
return nil, &document.InvalidMarshalError{"map key cannot be empty"}
148+
return nil, &document.InvalidMarshalError{Message: "map key cannot be empty"}
149149
}
150150

151151
cv, err := e.encode(rv.MapIndex(key), serde.Tag{})

0 commit comments

Comments
 (0)