-
Notifications
You must be signed in to change notification settings - Fork 4
Expand file tree
/
Copy pathevaluate_async.py
More file actions
327 lines (286 loc) · 11.1 KB
/
evaluate_async.py
File metadata and controls
327 lines (286 loc) · 11.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
"""Async evaluation script for migration agent using RolloutClient async APIs."""
import argparse
import asyncio
import json
import logging
import time
from pathlib import Path
from eval_utils import append_result_to_file, get_s3_folder_uris, load_config, prepare_payload
from agentcore_rl_toolkit import RolloutClient
logging.basicConfig(level=logging.INFO)
logger = logging.getLogger(__name__)
async def run_batch_mode(client, payloads, s3_folder_uris, result_path, max_concurrent, timeout):
"""Run evaluation using client.run_batch_async() — managed async batch lifecycle."""
completed = 0
succeeded = 0
failed = 0
task_successes = 0
async for item in client.run_batch_async(payloads, max_concurrent_sessions=max_concurrent, timeout=timeout):
completed += 1
record = {
"index": item.index,
"success": item.success,
"input_uri": s3_folder_uris[item.index],
}
if item.success:
succeeded += 1
record["result"] = item.result
record["elapsed"] = item.elapsed
rewards = item.result.get("rewards")
if rewards == 1:
task_successes += 1
logger.info(
f"[{completed}/{len(payloads)}] Index {item.index} completed in {item.elapsed:.1f}s - "
f"rewards: {rewards}"
)
else:
failed += 1
record["error"] = item.error
record["elapsed"] = item.elapsed
logger.warning(
f"[{completed}/{len(payloads)}] Index {item.index} failed in {item.elapsed:.1f}s: {item.error}"
)
append_result_to_file(result_path, record)
return succeeded, failed, task_successes
async def run_individual_mode(client, payloads, s3_folder_uris, result_path, timeout):
"""Run evaluation using invoke_async() + gather — two-step pattern for training frameworks."""
# Step 1: Fire all invoke_async concurrently
# (rate limiter paces at 25 TPS, cold starts don't block each other)
# return_exceptions=True so one failed submission doesn't cancel the rest
submit_tasks = [asyncio.create_task(client.invoke_async(p)) for p in payloads]
submit_results = await asyncio.gather(*submit_tasks, return_exceptions=True)
# Separate successful futures from submission failures
futures = [] # (idx, RolloutFuture)
submit_failures = [] # (idx, Exception)
for idx, result in enumerate(submit_results):
if isinstance(result, BaseException):
submit_failures.append((idx, result))
else:
futures.append((idx, result))
if submit_failures:
logger.warning(f"{len(submit_failures)} submissions failed, {len(futures)} succeeded")
logger.info(f"{len(futures)} requests submitted, gathering results...")
# Step 2: Gather all results concurrently
results = await asyncio.gather(
*[f.result_async(timeout=timeout) for _, f in futures],
return_exceptions=True,
)
# Process results
succeeded = 0
failed = 0
task_successes = 0
# Record submission failures first
for idx, exc in submit_failures:
failed += 1
record = {
"index": idx,
"input_uri": s3_folder_uris[idx],
"success": False,
"error": f"Submission failed: {exc}",
"elapsed": 0.0,
}
logger.warning(f"[{failed}/{len(payloads)}] Index {idx} submission failed: {exc}")
append_result_to_file(result_path, record)
# Record gather results
for i, result in enumerate(results):
idx, future = futures[i]
record = {
"index": idx,
"input_uri": s3_folder_uris[idx],
}
if isinstance(result, BaseException):
failed += 1
record["success"] = False
record["error"] = str(result)
record["elapsed"] = future.elapsed()
logger.warning(
f"[{succeeded + failed}/{len(payloads)}] Index {idx} failed " f"in {future.elapsed():.1f}s: {result}"
)
else:
succeeded += 1
record["success"] = True
record["result"] = result
record["elapsed"] = future.elapsed()
rewards = result.get("rewards")
if rewards == 1:
task_successes += 1
logger.info(
f"[{succeeded + failed}/{len(payloads)}] Index {idx} completed "
f"in {future.elapsed():.1f}s - rewards: {rewards}"
)
append_result_to_file(result_path, record)
return succeeded, failed, task_successes
async def main():
config = load_config()
agentcore_config = config.get("agentcore", {})
eval_config = config.get("eval", {})
parser = argparse.ArgumentParser(description="Async evaluation of migration agent on benchmark")
parser.add_argument(
"--mode",
type=str,
choices=["batch", "individual"],
default="batch",
help="Evaluation mode: 'batch' uses run_batch_async, 'individual' uses invoke_async + gather",
)
parser.add_argument(
"--agent_arn",
type=str,
default=agentcore_config.get("agent_arn"),
help="Agent ARN (example: arn:aws:bedrock-agentcore:{region}:{account_id}:runtime/{agent_id})",
)
parser.add_argument(
"--s3_input_bucket",
type=str,
default=eval_config.get("s3_input_bucket"),
help="S3 bucket for retrieving input repositories",
)
parser.add_argument(
"--s3_output_bucket",
type=str,
default=eval_config.get("s3_output_bucket"),
help="S3 bucket for storing rollout results",
)
parser.add_argument(
"--base_url",
type=str,
default=eval_config.get("base_url"),
help="vLLM server URL for model inference",
)
parser.add_argument(
"--model_id",
type=str,
default=eval_config.get("model_id"),
help="Model ID for inference",
)
parser.add_argument(
"--exp_id",
type=str,
default="eval_async",
help="Experiment ID for organizing results",
)
parser.add_argument(
"--max_concurrent",
type=int,
default=100,
help="Max concurrent ACR sessions (batch mode only)",
)
parser.add_argument(
"--timeout",
type=float,
default=3600.0,
help="Timeout in seconds per request (default: 3600s / 60 min)",
)
parser.add_argument(
"--limit",
type=int,
default=None,
help="Limit number of repositories to evaluate (for testing)",
)
parser.add_argument(
"--max_pool_connections",
type=int,
default=10,
help="Max urllib3 connection pool size for boto3 clients (default: 10). "
"If this value is smaller than --max_concurrent, you may see urllib3 warnings "
"'Connection pool is full, discarding connection'. This is not an error — "
"requests still succeed, but excess connections are created and discarded "
"instead of being reused from the pool, adding minor TCP/TLS overhead. ",
)
parser.add_argument(
"--sampling_params",
type=str,
default=eval_config.get("sampling_params"),
help="Sampling parameters as JSON string (e.g. '{\"temperature\": 0.7}')",
)
parser.add_argument(
"--require_maximal_migration",
action="store_true",
default=False,
help="Whether a repository is evaluated under maximal migration",
)
parser.add_argument(
"--apply_static_update",
action="store_true",
default=False,
help="Whether to apply static update on JDK and dependency versions",
)
parser.add_argument(
"--use_dependency_search_tool",
action="store_true",
default=False,
help="Whether to allow dependency search tool for agent",
)
args = parser.parse_args()
# Validation
if not args.agent_arn:
parser.error("--agent_arn is required (or set agentcore.agent_arn in config.toml)")
if not args.s3_input_bucket:
parser.error("--s3_input_bucket is required")
if not args.s3_output_bucket:
parser.error("--s3_output_bucket is required")
# Get repository folders
logger.info(f"Listing repositories from {args.s3_input_bucket}...")
s3_folder_uris = get_s3_folder_uris(args.s3_input_bucket)
if not s3_folder_uris:
logger.error(f"No folders found in {args.s3_input_bucket}")
return
# Apply limit if specified
if args.limit:
s3_folder_uris = s3_folder_uris[: args.limit]
logger.info(f"Found {len(s3_folder_uris)} repositories to evaluate")
# Prepare payloads
payloads = [
prepare_payload(uri, args.require_maximal_migration, args.apply_static_update, args.use_dependency_search_tool)
for uri in s3_folder_uris
]
# Setup results directory and file
results_dir = Path(__file__).parent / "results"
results_dir.mkdir(exist_ok=True)
result_path = results_dir / f"{args.exp_id}.jsonl"
# Error if file already exists to prevent accidental overwrites
if result_path.exists():
logger.error(f"Results file already exists: {result_path}")
logger.error("Delete the file or use a different --exp_id")
return
logger.info(f"Results will be written to: {result_path}")
# Parse sampling params
sampling_params = {}
if args.sampling_params:
if isinstance(args.sampling_params, str):
sampling_params = json.loads(args.sampling_params)
else:
sampling_params = dict(args.sampling_params)
# Create client
client = RolloutClient(
agent_runtime_arn=args.agent_arn,
s3_bucket=args.s3_output_bucket,
exp_id=args.exp_id,
base_url=args.base_url,
model_id=args.model_id,
max_pool_connections=args.max_pool_connections,
sampling_params=sampling_params,
)
# Run evaluation
logger.info(f"Starting async evaluation (mode={args.mode}, timeout={args.timeout}s)...")
benchmark_start = time.time()
if args.mode == "batch":
logger.info(f"Batch mode: max_concurrent={args.max_concurrent}")
succeeded, failed, task_successes = await run_batch_mode(
client, payloads, s3_folder_uris, result_path, args.max_concurrent, args.timeout
)
else:
logger.info(f"Individual mode: submitting all {len(payloads)} requests concurrently")
succeeded, failed, task_successes = await run_individual_mode(
client, payloads, s3_folder_uris, result_path, args.timeout
)
# Summary
total_repos = len(payloads)
success_rate = task_successes / total_repos if total_repos > 0 else 0
total_time = time.time() - benchmark_start
logger.info("=" * 50)
logger.info(f"Evaluation complete: {succeeded} succeeded, {failed} failed")
logger.info(f"Task success rate: {task_successes}/{total_repos} ({success_rate:.1%})")
logger.info(f"Total benchmark time: {total_time:.1f}s ({total_time / 60:.1f}m)")
logger.info(f"Results saved to: {result_path}")
if __name__ == "__main__":
asyncio.run(main())