Skip to content

Commit 09a65c4

Browse files
authored
refactor: remove legacy frameworks/strands vLLMModel (#82)
1 parent 5c0f244 commit 09a65c4

4 files changed

Lines changed: 3 additions & 130 deletions

File tree

AGENTS.md

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ cd examples/strands_math_agent && uv sync && uv run python rl_app.py
4747
| File | Purpose |
4848
|------|---------|
4949
| `src/agentcore_rl_toolkit/app.py` | `AgentCoreRLApp` base class, `@rollout_entrypoint` decorator |
50-
| `src/agentcore_rl_toolkit/frameworks/strands/vllm_model.py` | Legacy `vLLMModel` for client-side token ID collection (replaced by rllm-model-gateway) |
5150
| `src/agentcore_rl_toolkit/client.py` | `RolloutClient` and `RolloutFuture` for training integration and batch evaluation |
5251
| `src/agentcore_rl_toolkit/reward_function.py` | `RewardFunction` base class |
5352
| `examples/strands_math_agent/` | GSM8K math agent example |
@@ -65,11 +64,7 @@ agentcore-rl-toolkit/
6564
│ ├── __init__.py # Public exports
6665
│ ├── app.py # AgentCoreRLApp base class
6766
│ ├── client.py # RolloutClient for batch evaluation
68-
│ ├── reward_function.py # RewardFunction base class
69-
│ └── frameworks/
70-
│ └── strands/
71-
│ ├── __init__.py
72-
│ └── vllm_model.py # Legacy vLLMModel (client-side token ID collection)
67+
│ └── reward_function.py # RewardFunction base class
7368
├── examples/
7469
│ ├── strands_math_agent/ # GSM8K example
7570
│ │ ├── .bedrock_agentcore/ # Dockerfiles for deployment
@@ -226,11 +221,6 @@ On the client side, `RolloutClient` and `RolloutFuture` are the complement to th
226221

227222
#### Utilities
228223

229-
**vLLMModel** (`src/agentcore_rl_toolkit/frameworks/strands/vllm_model.py`) — **Legacy**
230-
- Client-side token ID collection wrapper around Strands `OpenAIModel`
231-
- Replaced by [rllm-model-gateway](https://github.com/rllm-org/rllm/tree/main/rllm-model-gateway), which captures token IDs transparently at the HTTP layer as a proxy between the agent and inference server — no custom model wrapper needed in agent code
232-
- The file is retained for backward compatibility but examples now use standard `OpenAIModel`
233-
234224
**RewardFunction** (`src/agentcore_rl_toolkit/reward_function.py`)
235225
- Base class for reward implementations
236226
- Can be any function that outputs a scalar
@@ -406,11 +396,7 @@ See `.env.example` for template. The build script sources `.env` for deployment
406396

407397
### Adding Support for a New Framework
408398

409-
Agents use their framework's native OpenAI-compatible model class (e.g., `OpenAIModel` for Strands), so framework-specific model wrappers are generally not needed. If other framework-specific utilities are needed:
410-
411-
1. Create `src/agentcore_rl_toolkit/frameworks/{framework}/`
412-
2. Implement the utility
413-
3. Export in the framework's `__init__.py`
399+
Agents use their framework's native OpenAI-compatible model class (e.g., `OpenAIModel` for Strands), so framework-specific model wrappers are not needed. Point the model's `base_url` at the training inference server and token capture is handled at the infrastructure layer — no per-framework code lives in this package.
414400

415401
### Running Tests
416402

examples/strands_taubench_agent/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Two separate packages are involved — don't confuse them:
5858

5959
| Package | What it gives you | Source |
6060
|---------|-------------------|--------|
61-
| `agentcore-rl-toolkit` (this repo) | The RL SDK (`AgentCoreRLApp`, `@rollout_entrypoint`, `vLLMModel`) **and this example** | `git clone` (below) |
61+
| `agentcore-rl-toolkit` (this repo) | The RL SDK (`AgentCoreRLApp`, `@rollout_entrypoint`) **and this example** | `git clone` (below) |
6262
| `bedrock-agentcore-starter-toolkit` | AWS's `agentcore` CLI used to deploy to ACR | `pip install` (below) |
6363

6464
## Installation

src/agentcore_rl_toolkit/frameworks/strands/__init__.py

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/agentcore_rl_toolkit/frameworks/strands/vllm_model.py

Lines changed: 0 additions & 110 deletions
This file was deleted.

0 commit comments

Comments
 (0)