Skip to content

Commit 1b42a26

Browse files
committed
fix: validation script fixes
1 parent 3848b20 commit 1b42a26

7 files changed

Lines changed: 9 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### **Added**
1111

1212
### **Changed**
13+
- updated GitHub repo creation in `sagemaker-templates` module to support GitHub organizations
1314

1415
## v2.1.0
1516

modules/sagemaker/sagemaker-templates/pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.ruff]
22
line-length = 120
3-
target-version = "py38"
3+
target-version = "py310"
44
extend-include = ["*.ipynb"]
55

66
exclude = [
@@ -24,7 +24,7 @@ select = ["F", "I", "E", "W"]
2424
fixable = ["ALL"]
2525

2626
[tool.mypy]
27-
python_version = "3.8"
27+
python_version = "3.10"
2828
strict = true
2929
ignore_missing_imports = true
3030
disallow_untyped_decorators = false

modules/sagemaker/sagemaker-templates/templates/finetune_llm_evaluation/pipeline_constructs/build_pipeline_construct.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,7 @@ def __init__(
228228
"sagemaker:ListTags",
229229
],
230230
resources=[
231-
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:pipeline/"
232-
f"{sagemaker_pipeline_name}",
231+
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:pipeline/{sagemaker_pipeline_name}",
233232
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:pipeline/"
234233
f"{sagemaker_pipeline_name}/execution/*",
235234
],

modules/sagemaker/sagemaker-templates/templates/finetune_llm_evaluation/seed_code/build_app/source_scripts/evaluate.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def evaluate_model(args: Any) -> None:
7777
os.makedirs(args.model_dir, exist_ok=True)
7878
tar_file.extractall(args.model_dir)
7979

80-
logger.info(f"Decompressed Model assets: {os.listdir( args.model_dir )}")
80+
logger.info(f"Decompressed Model assets: {os.listdir(args.model_dir)}")
8181

8282
# Load test dataset
8383
test_dataset = load_from_disk(args.test_data_dir)
@@ -88,7 +88,7 @@ def evaluate_model(args: Any) -> None:
8888
# ensure that we do not have any trailing/leading whitespaces, this can lead to issues during inference
8989
test_data = test_dataset.map(lambda sample: {"prompt": sample["prompt"].strip()})
9090
logger.info("Loading test dataset")
91-
logger.info(f"Test dataset has {len( test_data )} samples")
91+
logger.info(f"Test dataset has {len(test_data)} samples")
9292

9393
model = AutoModelForCausalLM.from_pretrained(args.model_dir, device_map="auto", torch_dtype=torch.float16)
9494

modules/sagemaker/sagemaker-templates/templates/finetune_llm_evaluation/seed_code/build_app/source_scripts/train.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def create_peft_model(model: Any, gradient_checkpointing: bool = True, bf16: boo
7171

7272
# get lora target modules
7373
modules = find_all_linear_names(model)
74-
logger.info(f"Found {len( modules )} modules to quantize: {modules}")
74+
logger.info(f"Found {len(modules)} modules to quantize: {modules}")
7575

7676
peft_config = LoraConfig(
7777
r=64,

modules/sagemaker/sagemaker-templates/templates/model_deploy/product_stack.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ def __init__(
111111
dev_region: str = Aws.REGION
112112

113113
model_package_arn = (
114-
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:model-package/"
115-
f"{model_package_group_name}/*"
114+
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:model-package/{model_package_group_name}/*"
116115
)
117116
model_package_group_arn = (
118117
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:model-package-group/"

modules/sagemaker/sagemaker-templates/templates/xgboost_abalone/pipeline_constructs/build_pipeline_construct.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,7 @@ def __init__(
262262
"sagemaker:ListTags",
263263
],
264264
resources=[
265-
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:pipeline/"
266-
f"{sagemaker_pipeline_name}",
265+
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:pipeline/{sagemaker_pipeline_name}",
267266
f"arn:{Aws.PARTITION}:sagemaker:{Aws.REGION}:{Aws.ACCOUNT_ID}:pipeline/"
268267
f"{sagemaker_pipeline_name}/execution/*",
269268
],

0 commit comments

Comments
 (0)