|
| 1 | +"""Verify that cdk synth produces correct SageMaker resource names. |
| 2 | +
|
| 3 | +This test mocks the SageMaker API call (get_approved_package) and all |
| 4 | +required environment variables, then synthesizes the DeployEndpointStack |
| 5 | +and asserts that stage_name drives unique SageMaker resource names. |
| 6 | +""" |
| 7 | + |
| 8 | +import json |
| 9 | +import os |
| 10 | +import sys |
| 11 | +from unittest.mock import MagicMock |
| 12 | + |
| 13 | +# -- Dummy environment variables (must be set before importing constants) ---- |
| 14 | +_ENV = { |
| 15 | + "MODEL_BUCKET_ARN": "arn:aws:s3:::test-model-bucket", |
| 16 | + "MODEL_PACKAGE_GROUP_NAME": "test-model-group", |
| 17 | + "DEV_ACCOUNT_ID": "111111111111", |
| 18 | + "DEV_REGION": "us-east-1", |
| 19 | + "DEV_VPC_ID": "vpc-abc123", |
| 20 | + "DEV_SUBNET_IDS": json.dumps(["subnet-aaa"]), |
| 21 | + "DEV_SECURITY_GROUP_IDS": json.dumps(["sg-aaa"]), |
| 22 | + "PRE_PROD_ACCOUNT_ID": "222222222222", |
| 23 | + "PRE_PROD_REGION": "us-east-1", |
| 24 | + "PRE_PROD_VPC_ID": "vpc-def456", |
| 25 | + "PRE_PROD_SUBNET_IDS": json.dumps(["subnet-bbb"]), |
| 26 | + "PRE_PROD_SECURITY_GROUP_IDS": json.dumps(["sg-bbb"]), |
| 27 | + "PROD_ACCOUNT_ID": "333333333333", |
| 28 | + "PROD_REGION": "us-east-1", |
| 29 | + "PROD_VPC_ID": "vpc-ghi789", |
| 30 | + "PROD_SUBNET_IDS": json.dumps(["subnet-ccc"]), |
| 31 | + "PROD_SECURITY_GROUP_IDS": json.dumps(["sg-ccc"]), |
| 32 | + "PROJECT_NAME": "test-project", |
| 33 | + "PROJECT_ID": "test-id", |
| 34 | + "ENABLE_NETWORK_ISOLATION": "true", |
| 35 | + "ENABLE_DATA_CAPTURE": "true", |
| 36 | + "ENABLE_MANUAL_APPROVAL": "false", |
| 37 | + "ENABLE_EVENTBRIDGE_TRIGGER": "false", |
| 38 | +} |
| 39 | + |
| 40 | +# Set env vars before any imports that read them |
| 41 | +os.environ.update(_ENV) |
| 42 | + |
| 43 | +# Stub out the get_approved_package module before it tries to create a boto3 client. |
| 44 | +# The module creates a boto3.client("sagemaker") at import time, so we must |
| 45 | +# intercept it before deploy_endpoint_stack imports it. |
| 46 | +_fake_get_approved = MagicMock(return_value="arn:aws:sagemaker:us-east-1:111111111111:model-package/test-group/1") |
| 47 | +_fake_module = MagicMock() |
| 48 | +_fake_module.get_approved_package = _fake_get_approved |
| 49 | +sys.modules["deploy_app.get_approved_package"] = _fake_module |
| 50 | + |
| 51 | +import aws_cdk as cdk # noqa: E402 |
| 52 | +from aws_cdk import assertions # noqa: E402 |
| 53 | +from deploy_app.deploy_endpoint_stack import DeployEndpointStack # noqa: E402 |
| 54 | + |
| 55 | + |
| 56 | +def _synth_deploy_endpoint_stack(stage_name: str = "dev") -> assertions.Template: |
| 57 | + """Synthesize a standalone DeployEndpointStack and return its Template.""" |
| 58 | + # Reset the mock so each test gets a fresh call count |
| 59 | + _fake_get_approved.reset_mock() |
| 60 | + |
| 61 | + # Use a Stage with a concrete account (matches real usage in pipeline_stack.py) |
| 62 | + app = cdk.App() |
| 63 | + stage = cdk.Stage( |
| 64 | + app, |
| 65 | + "TestStage", |
| 66 | + env=cdk.Environment(account="111111111111", region="us-east-1"), |
| 67 | + ) |
| 68 | + stack = DeployEndpointStack( |
| 69 | + stage, |
| 70 | + "test-project-endpoint", |
| 71 | + stage_name=stage_name, |
| 72 | + vpc_id="vpc-abc123", |
| 73 | + subnet_ids=["subnet-aaa"], |
| 74 | + security_group_ids=["sg-aaa"], |
| 75 | + ) |
| 76 | + |
| 77 | + return assertions.Template.from_stack(stack) |
| 78 | + |
| 79 | + |
| 80 | +def _get_endpoint_name(template: assertions.Template) -> str: |
| 81 | + """Extract the SageMaker endpoint name from a synthesized template.""" |
| 82 | + endpoints = template.find_resources("AWS::SageMaker::Endpoint") |
| 83 | + assert len(endpoints) == 1, f"Expected 1 endpoint, found {len(endpoints)}" |
| 84 | + props = next(iter(endpoints.values()))["Properties"] |
| 85 | + return props["EndpointName"] |
| 86 | + |
| 87 | + |
| 88 | +def test_stage_name_produces_unique_endpoint_names(): |
| 89 | + """Different stage_name values must produce different SageMaker endpoint names.""" |
| 90 | + dev_template = _synth_deploy_endpoint_stack(stage_name="dev") |
| 91 | + prod_template = _synth_deploy_endpoint_stack(stage_name="prod") |
| 92 | + |
| 93 | + dev_ep = _get_endpoint_name(dev_template) |
| 94 | + prod_ep = _get_endpoint_name(prod_template) |
| 95 | + |
| 96 | + assert dev_ep != prod_ep, f"dev and prod endpoint names should differ, both are '{dev_ep}'" |
| 97 | + assert "-dev-" in dev_ep, f"Expected '-dev-' in endpoint name, got '{dev_ep}'" |
| 98 | + assert "-prod-" in prod_ep, f"Expected '-prod-' in endpoint name, got '{prod_ep}'" |
| 99 | + |
| 100 | + |
| 101 | +def test_role_references_managed_policy(): |
| 102 | + """The ModelExecutionRole must reference the ManagedPolicy (dependency chain).""" |
| 103 | + template = _synth_deploy_endpoint_stack() |
| 104 | + |
| 105 | + template.has_resource_properties( |
| 106 | + "AWS::IAM::Role", |
| 107 | + assertions.Match.object_like( |
| 108 | + { |
| 109 | + "AssumeRolePolicyDocument": { |
| 110 | + "Statement": [ |
| 111 | + { |
| 112 | + "Action": "sts:AssumeRole", |
| 113 | + "Effect": "Allow", |
| 114 | + "Principal": {"Service": "sagemaker.amazonaws.com"}, |
| 115 | + } |
| 116 | + ], |
| 117 | + }, |
| 118 | + "ManagedPolicyArns": assertions.Match.array_with( |
| 119 | + [{"Ref": assertions.Match.string_like_regexp("ModelExecutionPolicy.*")}] |
| 120 | + ), |
| 121 | + } |
| 122 | + ), |
| 123 | + ) |
0 commit comments