Remove unnecessary foreign key operation overrides

Author: danielfrankcom

aurora_dsql_django/schema.py

@@ -49,8 +49,6 @@ class DatabaseSchemaEditor(schema.DatabaseSchemaEditor):
 
     # These "ALTER TABLE" operations are not supported.
     sql_create_pk = ""
-    sql_create_fk = ""
-    sql_delete_fk = ""
     sql_create_check = ""
     sql_delete_check = ""
     sql_delete_constraint = ""

aurora_dsql_django/tests/unit/test_schema.py

@@ -11,7 +11,6 @@ def setUp(self):
         self.schema_editor = DatabaseSchemaEditor(self.connection)
 
     def test_sql_attributes(self):
-        self.assertEqual(self.schema_editor.sql_delete_fk, "")
         self.assertEqual(self.schema_editor.sql_create_pk, "")
         self.assertEqual(self.schema_editor.sql_create_index,
                          "CREATE INDEX ASYNC %(name)s ON %(table)s%(using)s (%(columns)s)%(include)s%(extra)s%(condition)s")
@@ -24,7 +23,6 @@ def test_sql_attributes(self):
             self.schema_editor.sql_update_with_default,
             "UPDATE %(table)s SET %(column)s = %(default)s WHERE %(column)s IS NULL"
         )
-        self.assertEqual(self.schema_editor.sql_create_fk, "")
         self.assertEqual(self.schema_editor.sql_create_check, "")
         self.assertEqual(self.schema_editor.sql_delete_check, "")
         self.assertEqual(self.schema_editor.sql_delete_constraint, "")

aurora_dsql_django/tests/unit/test_wrapper.py

@@ -0,0 +1,55 @@
+import unittest
+from unittest.mock import MagicMock, patch
+import django
+from django.conf import settings
+from django.db import models
+from aurora_dsql_django.base import DatabaseWrapper
+from aurora_dsql_django.features import DatabaseFeatures
+from aurora_dsql_django.schema import DatabaseSchemaEditor
+
+if not settings.configured:
+    settings.configure(
+        INSTALLED_APPS=['django.contrib.contenttypes'],
+        DATABASES={'default': {'ENGINE': 'aurora_dsql_django'}},
+        USE_TZ=True,
+    )
+    django.setup()
+
+
+class TestWrapper(unittest.TestCase):
+    """Test Aurora DSQL wrapper behavior when all parts are working together"""
+
+    def setUp(self):
+        self.connection = DatabaseWrapper({})
+        self.connection.connection = MagicMock()
+        self.connection.connection.encoding = 'utf8'
+
+        # Configure mock to use real components.
+        self.connection.features = DatabaseFeatures(self.connection)
+        self.schema_editor = DatabaseSchemaEditor(self.connection)
+
+    def test_foreign_key_sql_generation(self):
+        """Ensure foreign key SQL is not generated when the feature is disabled"""
+
+        class ParentModel(models.Model):
+            class Meta:
+                app_label = 'test_app'
+
+        class ChildModel(models.Model):
+            parent = models.ForeignKey(ParentModel, on_delete=models.CASCADE)
+
+            class Meta:
+                app_label = 'test_app'
+
+        # Mock execute to capture SQL without actually running it.
+        with patch.object(self.schema_editor, 'execute'):
+            with self.schema_editor:
+                self.schema_editor.create_model(ChildModel)
+
+                # Check that no foreign key SQL was deferred.
+                foreign_key_statements = [sql for sql in self.schema_editor.deferred_sql if 'FOREIGN KEY' in str(sql)]
+                self.assertListEqual([], foreign_key_statements, "Should not generate foreign key SQL")
+
+
+if __name__ == '__main__':
+    unittest.main()