address some comments

Author: azkrishpy

examples/curl_content_length_example.c

@@ -87,9 +87,6 @@ struct aws_h1_stream {
         /* Whether a "request handler" stream has a response to send.
          * Has mirror variable in synced_data */
         bool has_outgoing_response : 1;
-
-        /* Total bytes written so far for Content-Length validation */
-        uint64_t incremental_content_written;
     } thread_data;
 
     /* Any thread may touch this data, but the connection's lock must be held.

include/aws/http/private/h1_stream.h

@@ -926,11 +926,12 @@ AWS_HTTP_API int aws_http1_stream_write_chunk(
 
 /**
  * Write data to an HTTP stream in a protocol-agnostic way.
- * Works with both HTTP/1.1 (with Content-Length) and HTTP/2.
+ * Works with both HTTP/1.1 and HTTP/2.
  *
  * The stream must have specified `use_manual_data_writes` during request creation.
  * Note: `http2_use_manual_data_writes` also works for HTTP/2 but should be deprecated in favor of this unified flag.
- * For HTTP/1.1: The request must have a Content-Length header and must NOT have a body stream set.
+ * For HTTP/1.1: The request must have either a Content-Length header or Transfer-Encoding: chunked header,
+ *               and must NOT have a body stream set.
  *
  * For client streams, activate() must be called before any data is written.
  * For server streams, the response must be submitted before any data is written.

include/aws/http/request_response.h

@@ -438,7 +438,7 @@ static int s_stream_write_data(
     }
 
     if (is_chunked) {
-        /* Convert write_data into chunk(s) for chunked encoding */
+        /* Convert write_data into a chunk for chunked encoding */
         int64_t data_len = 0;
         if (aws_input_stream_get_length(options->data, &data_len)) {
             AWS_LOGF_ERROR(
@@ -454,21 +454,7 @@ static int s_stream_write_data(
             .on_complete = options->on_complete,
             .user_data = options->user_data,
         };
-        if (aws_http1_stream_write_chunk(stream_base, &chunk_opts)) {
-            return AWS_OP_ERR;
-        }
-
-        /* If end_stream, also submit terminating zero-length chunk */
-        if (options->end_stream) {
-            struct aws_http1_chunk_options terminator = {
-                .chunk_data_size = 0,
-            };
-            if (aws_http1_stream_write_chunk(stream_base, &terminator)) {
-                return AWS_OP_ERR;
-            }
-        }
-
-        return AWS_OP_SUCCESS;
+        return aws_http1_stream_write_chunk(stream_base, &chunk_opts);
     }
 
     /* Content-Length path: create data write and push to pending list */

source/h1_stream.c

@@ -159,12 +159,10 @@ add_test_case(h1_client_connection_close_before_request_finishes_with_buffer_for
 add_test_case(h1_client_connection_close_before_request_finishes_with_buffer_stream_cancel)
 add_test_case(h1_client_write_data_single_chunk)
 add_test_case(h1_client_write_data_multiple_chunks)
-add_test_case(h1_client_write_data_not_enabled_with_body)
-add_test_case(h1_client_write_data_not_enabled_no_body)
+add_test_case(h1_client_write_data_not_enabled)
 add_test_case(h1_client_write_data_after_final)
 add_test_case(h1_client_write_data_exceeds_content_length)
 add_test_case(h1_client_write_data_less_than_content_length)
-add_test_case(h1_client_unified_write_data_api)
 add_test_case(h1_client_write_data_chunked_single)
 add_test_case(h1_client_write_data_chunked_multiple)
 
@@ -525,7 +523,6 @@ add_test_case(h2_client_batch_auto_window_update)
 add_test_case(h2_client_batch_manual_window_update)
 add_test_case(h2_client_cap_manual_window_update)
 add_test_case(h2_client_unified_write_data_api)
-add_test_case(h2_client_backward_compat_write_data)
 
 add_test_case(server_new_destroy)
 add_test_case(server_new_destroy_tcp)