address comments

Author: Krish

tests/CMakeLists.txt

@@ -652,9 +652,7 @@ add_test_case(test_no_proxy_invalid_patterns)
 add_test_case(test_no_proxy_invalid_host_inputs)
 
 add_test_case(http_tunnel_proxy_connection_success)
-if(NOT APPLE)
 add_test_case(https_tunnel_proxy_connection_success)
-endif()
 add_test_case(http_tunnel_proxy_connection_failure_connect)
 add_test_case(https_tunnel_proxy_connection_failure_connect)
 add_test_case(https_tunnel_proxy_connection_failure_tls)

tests/test_connection.c

@@ -735,18 +735,11 @@ static int s_test_connection_customized_alpn_error_with_unknown_return_string(
     tester.wait_client_connection_num = 1;
     tester.wait_server_connection_num = 1;
 
-    // TODO: Investigate further and fix behavior taking into account the recent migration
-    // to newer Apple Netowrk Frameowrk on aws-c-io. Implemented temporary fix for CI tests.
-    // CI fails on local for some machines. Still under investigation.
-
-    // #ifndef __APPLE__ /* Server side ALPN doesn't work for MacOS */
     ASSERT_FAILS(s_tester_wait(&tester, s_tester_connection_setup_pred));
     /* Assert that we have the negotiated protocol and error returned from callback */
     ASSERT_TRUE(aws_byte_buf_eq_c_str(&tester.negotiated_protocol, customized_alpn_string));
     ASSERT_INT_EQUALS(aws_last_error(), AWS_ERROR_HTTP_UNSUPPORTED_PROTOCOL);
-    // #else
-    //    ASSERT_SUCCESS(s_tester_wait(&tester, s_tester_connection_setup_pred));
-    // #endif
+
     /* clean up */
     release_all_client_connections(&tester);
     release_all_server_connections(&tester);

tests/test_proxy.c

@@ -346,9 +346,13 @@ AWS_TEST_CASE(
  * Test the happy path by verifying CONNECT request, tls upgrade attempt
  * TODO: This test is temporarily disabled on Apple platforms following a breaking change
  * due to migration to the new Apple Network Framework. Investigations underway for rethinking
- * proxy implementation on Apple platforms. Test should be re-enabled post-fix on CMakeLists.txt.
+ * proxy implementation on Apple platforms. Test should be re-enabled post-fix.
  */
 static int s_test_https_tunnel_proxy_connection_success(struct aws_allocator *allocator, void *ctx) {
+#if defined(AWS_OS_APPLE)
+    (void)allocator;
+    return AWS_OP_SKIP;
+#endif
     (void)ctx;
 
     struct mocked_proxy_test_options options = {