Skip to content

Commit 5931ba0

Browse files
committed
Fix write_data tests: add Content-Length: 0 to responses for indeterminate-length compatibility
1 parent 5ed902f commit 5931ba0

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

tests/test_h1_client.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5226,7 +5226,7 @@ H1_CLIENT_TEST_CASE(h1_client_write_data_single_chunk) {
52265226
ASSERT_INT_EQUALS(1, callback_tester.num_callbacks);
52275227
ASSERT_INT_EQUALS(AWS_ERROR_SUCCESS, callback_tester.last_error_code);
52285228

5229-
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\n\r\n"));
5229+
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n"));
52305230
testing_channel_drain_queued_tasks(&fixture.tester.testing_channel);
52315231

52325232
ASSERT_TRUE(fixture.stream_tester.complete);
@@ -5285,7 +5285,7 @@ H1_CLIENT_TEST_CASE(h1_client_write_data_multiple_chunks) {
52855285
ASSERT_INT_EQUALS(1, callback_tester2.num_callbacks);
52865286
ASSERT_INT_EQUALS(AWS_ERROR_SUCCESS, callback_tester2.last_error_code);
52875287

5288-
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\n\r\n"));
5288+
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n"));
52895289
testing_channel_drain_queued_tasks(&fixture.tester.testing_channel);
52905290

52915291
ASSERT_TRUE(fixture.stream_tester.complete);
@@ -5455,7 +5455,7 @@ H1_CLIENT_TEST_CASE(h1_client_write_data_chunked_single) {
54555455
ASSERT_INT_EQUALS(1, callback_tester.num_callbacks);
54565456
ASSERT_INT_EQUALS(AWS_ERROR_SUCCESS, callback_tester.last_error_code);
54575457

5458-
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\n\r\n"));
5458+
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n"));
54595459
testing_channel_drain_queued_tasks(&fixture.tester.testing_channel);
54605460

54615461
ASSERT_TRUE(fixture.stream_tester.complete);
@@ -5587,7 +5587,7 @@ H1_CLIENT_TEST_CASE(h1_client_write_data_null_data_content_length) {
55875587
ASSERT_INT_EQUALS(3, callback_tester.num_callbacks);
55885588
ASSERT_INT_EQUALS(AWS_ERROR_SUCCESS, callback_tester.last_error_code);
55895589

5590-
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\n\r\n"));
5590+
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n"));
55915591
testing_channel_drain_queued_tasks(&fixture.tester.testing_channel);
55925592

55935593
ASSERT_TRUE(fixture.stream_tester.complete);
@@ -5629,7 +5629,7 @@ H1_CLIENT_TEST_CASE(h1_client_write_data_null_data_chunked) {
56295629
ASSERT_INT_EQUALS(1, callback_tester.num_callbacks);
56305630
ASSERT_INT_EQUALS(AWS_ERROR_SUCCESS, callback_tester.last_error_code);
56315631

5632-
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\n\r\n"));
5632+
ASSERT_SUCCESS(testing_channel_push_read_str(&fixture.tester.testing_channel, "HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n"));
56335633
testing_channel_drain_queued_tasks(&fixture.tester.testing_channel);
56345634

56355635
ASSERT_TRUE(fixture.stream_tester.complete);
@@ -5674,6 +5674,10 @@ H1_CLIENT_TEST_CASE(h1_client_write_data_auto_chunked) {
56745674

56755675
/* Test: Response with no Content-Length or Transfer-Encoding has its body determined by connection closure */
56765676
H1_CLIENT_TEST_CASE(h1_client_response_indeterminate_length_body) {
5677+
(void)ctx;
5678+
struct tester tester;
5679+
ASSERT_SUCCESS(s_tester_init(&tester, allocator));
5680+
56775681
/* send request */
56785682
struct aws_http_message *request = s_new_default_get_request(allocator);
56795683

0 commit comments

Comments
 (0)