if it's stalled, also don't send the empty frame

TingDaoK · TingDaoK · commit 5c647b3d87f8 · 2025-06-05T17:36:35.000-07:00
diff --git a/source/h2_frames.c b/source/h2_frames.c
@@ -403,7 +403,7 @@ int aws_h2_encode_data_frame(
         }
     }
 
-    if (body_sub_buf.len == 0 && !body_ends_stream) {
+    if (body_sub_buf.len == 0 && !(flags & AWS_H2_FRAME_F_END_STREAM)) {
         /* This frame would have no useful information, don't even bother sending it */
         goto handle_nothing_to_send_right_now;
     }

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ int aws_h2_encode_data_frame(`
`403`	`403`	`}`
`404`	`404`	`}`
`405`	`405`
`406`		`- if (body_sub_buf.len == 0 && !body_ends_stream) {`
	`406`	`+ if (body_sub_buf.len == 0 && !(flags & AWS_H2_FRAME_F_END_STREAM)) {`
`407`	`407`	`/* This frame would have no useful information, don't even bother sending it */`
`408`	`408`	`goto handle_nothing_to_send_right_now;`
`409`	`409`	`}`