Localhost test mac (#398)

- for some reason the mac local host test was flaky on Mac.
- Looked into the log, seems like the server rejected the connection. I guess it could be too many concurrent connections were opened?
- Try to lower the number of connections open concurrently

Author: TingDaoK

.github/workflows/ci.yml

@@ -155,22 +155,21 @@ jobs:
         python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
         python3 builder.pyz build -p aws-c-http --cmake-extra=-DENABLE_LOCALHOST_INTEGRATION_TESTS=ON
 
-  # localhost tests are flaky on mac. disable for now, put fixing it in backlog
-  # localhost-test-mac:
-  #   runs-on: macos-11 # latest
-  #   steps:
-  #   - name: Checkout
-  #     uses: actions/checkout@v3
-  #   - name: Configure local host
-  #     run: |
-  #       python3 -m pip install h2
-  #       cd ./tests/py_localhost/
-  #       python3 server.py &
-  #       python3 non_tls_server.py &
-  #   - name: Build and test
-  #     run: |
-  #       python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
-  #       python3 builder.pyz build -p aws-c-http --cmake-extra=-DENABLE_LOCALHOST_INTEGRATION_TESTS=ON
+  localhost-test-mac:
+    runs-on: macos-11 # latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+    - name: Configure local host
+      run: |
+        python3 -m pip install h2
+        cd ./tests/py_localhost/
+        python3 server.py &
+        python3 non_tls_server.py &
+    - name: Build and test
+      run: |
+        python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
+        python3 builder.pyz build -p aws-c-http --cmake-extra=-DENABLE_LOCALHOST_INTEGRATION_TESTS=ON
 
   localhost-test-win:
     runs-on: windows-2022 # latest

tests/test_stream_manager.c

@@ -1311,12 +1311,12 @@ TEST_CASE(localhost_integ_h2_sm_acquire_stream_stress) {
     (void)ctx;
     struct aws_byte_cursor uri_cursor = aws_byte_cursor_from_c_str("https://localhost:8443/echo");
     struct aws_http_connection_monitoring_options monitor_opt = {
-        .allowable_throughput_failure_interval_seconds = 1,
+        .allowable_throughput_failure_interval_seconds = 2,
         .minimum_throughput_bytes_per_second = 1000,
     };
     enum aws_log_level log_level = AWS_LOG_LEVEL_DEBUG;
     struct sm_tester_options options = {
-        .max_connections = 100,
+        .max_connections = 50,
         .max_concurrent_streams_per_connection = 100,
         .connection_ping_period_ms = 100 * AWS_TIMESTAMP_MILLIS,
         .alloc = allocator,
@@ -1325,11 +1325,11 @@ TEST_CASE(localhost_integ_h2_sm_acquire_stream_stress) {
         .log_level = &log_level,
     };
     ASSERT_SUCCESS(s_tester_init(&options));
-    int num_to_acquire = 500 * 100;
-    ASSERT_SUCCESS(s_sm_stream_acquiring(num_to_acquire));
+    size_t num_to_acquire = 500 * 100;
+    ASSERT_SUCCESS(s_sm_stream_acquiring((int)num_to_acquire));
     ASSERT_SUCCESS(s_wait_on_streams_completed_count(num_to_acquire));
-    ASSERT_TRUE((int)s_tester.acquiring_stream_errors == 0);
-    ASSERT_TRUE((int)s_tester.stream_200_count == num_to_acquire);
+    ASSERT_UINT_EQUALS(s_tester.acquiring_stream_errors, 0);
+    ASSERT_UINT_EQUALS(s_tester.stream_200_count, num_to_acquire);
 
     return s_tester_clean_up();
 }
@@ -1410,18 +1410,10 @@ TEST_CASE(localhost_integ_h2_sm_acquire_stream_stress_with_body) {
     s_tester.length_sent = 2000;
     int num_to_acquire = 500 * 100;
 
-#ifdef AWS_OS_LINUX
-    /* Using Python hyper h2 server frame work, met a weird upload performance issue on Linux. Our client against nginx
-     * platform has not met the same issue. We assume it's because the server framework implementation. Use lower
-     * number of linux
-     */
-    num_to_acquire = 500;
-#endif
-
     ASSERT_SUCCESS(s_sm_stream_acquiring_with_body(num_to_acquire));
     ASSERT_SUCCESS(s_wait_on_streams_completed_count(num_to_acquire));
-    ASSERT_TRUE((int)s_tester.acquiring_stream_errors == 0);
-    ASSERT_TRUE((int)s_tester.stream_200_count == num_to_acquire);
+    ASSERT_UINT_EQUALS(s_tester.acquiring_stream_errors, 0);
+    ASSERT_UINT_EQUALS(s_tester.stream_200_count, num_to_acquire);
 
     return s_tester_clean_up();
 }