try bump to 22?

Author: TingDaoK

.github/workflows/ci.yml

@@ -10,7 +10,7 @@ env:
   BUILDER_SOURCE: releases
   BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
   PACKAGE_NAME: aws-c-http
-  LINUX_BASE_IMAGE: ubuntu-18-x64
+  LINUX_BASE_IMAGE: ubuntu-22-x64
   RUN: ${{ github.run_id }}-${{ github.run_number }}
   CRT_CI_ROLE: ${{ secrets.CRT_CI_ROLE_ARN }}
   AWS_DEFAULT_REGION: us-east-1

source/http2_stream_manager.c

@@ -584,22 +584,20 @@ static struct aws_h2_sm_connection *s_sm_connection_new(
 
 static void s_sm_connection_release_connection(struct aws_h2_sm_connection *sm_connection) {
     AWS_ASSERT(sm_connection->num_streams_assigned == 0);
-    AWS_FATAL_ASSERT(sm_connection->connection != NULL);
-    if (sm_connection->connection) {
-        /* Should only be invoked from the connection thread. */
-        AWS_ASSERT(aws_channel_thread_is_callers_thread(aws_http_connection_get_channel(sm_connection->connection)));
+    AWS_ASSERT(sm_connection->connection != NULL);
+    /* Should only be invoked from the connection thread. */
+    AWS_ASSERT(aws_channel_thread_is_callers_thread(aws_http_connection_get_channel(sm_connection->connection)));
 
-        s_lock_synced_data(sm_connection->stream_manager);
-        /* Remove this connection from the connection tracking list */
-        aws_linked_list_remove(&sm_connection->node);
-        s_unlock_synced_data(sm_connection->stream_manager);
-        int error = aws_http_connection_manager_release_connection(
-            sm_connection->stream_manager->connection_manager, sm_connection->connection);
-        AWS_ASSERT(!error);
-        (void)error;
-        sm_connection->connection = NULL;
-        aws_ref_count_release(&sm_connection->ref_count);
-    }
+    s_lock_synced_data(sm_connection->stream_manager);
+    /* Remove this connection from the connection tracking list */
+    aws_linked_list_remove(&sm_connection->node);
+    s_unlock_synced_data(sm_connection->stream_manager);
+    int error = aws_http_connection_manager_release_connection(
+        sm_connection->stream_manager->connection_manager, sm_connection->connection);
+    AWS_ASSERT(!error);
+    (void)error;
+    sm_connection->connection = NULL;
+    aws_ref_count_release(&sm_connection->ref_count);
 }
 
 static void s_sm_on_connection_acquired_failed_synced(

tests/test_stream_manager.c

@@ -1120,12 +1120,12 @@ TEST_CASE(h2_sm_mock_goaway) {
     /* Fake peer send goaway */
     struct sm_fake_connection *fake_connection = s_get_fake_connection(0);
     ASSERT_SUCCESS(h2_fake_peer_send_connection_preface_default_settings(&fake_connection->peer));
-    struct aws_byte_cursor EXTRA_LOG_info;
-    AWS_ZERO_STRUCT(EXTRA_LOG_info);
+    struct aws_byte_cursor debug_info;
+    AWS_ZERO_STRUCT(debug_info);
     struct aws_http_stream *stream = NULL;
     aws_array_list_front(&s_tester.streams, &stream);
     struct aws_h2_frame *peer_frame =
-        aws_h2_frame_new_goaway(allocator, aws_http_stream_get_id(stream), AWS_HTTP2_ERR_NO_ERROR, EXTRA_LOG_info);
+        aws_h2_frame_new_goaway(allocator, aws_http_stream_get_id(stream), AWS_HTTP2_ERR_NO_ERROR, debug_info);
     ASSERT_SUCCESS(h2_fake_peer_send_frame(&fake_connection->peer, peer_frame));
     testing_channel_drain_queued_tasks(&fake_connection->testing_channel);