Skip to content

Support on_h2_remote_end_stream#554

Merged
TingDaoK merged 3 commits into
mainfrom
on-remote-complete
Mar 25, 2026
Merged

Support on_h2_remote_end_stream#554
TingDaoK merged 3 commits into
mainfrom
on-remote-complete

Conversation

@TingDaoK
Copy link
Copy Markdown
Contributor

Issue #, if available:

  • In case where the request is still open, but the response should end with eos sent, currently there is no way to indicated that. If the implementation relies on the response to end the request, then the implement will result in deadlock

Description of changes:

  • Add a callback for on_h2_remote_end_stream to be invoked when client receives the end stream from the remote.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review March 25, 2026 20:31
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.61%. Comparing base (0d8e1a9) to head (a7fe133).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   79.76%   79.61%   -0.16%     
==========================================
  Files          28       28              
  Lines       11893    11936      +43     
==========================================
+ Hits         9487     9503      +16     
- Misses       2406     2433      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK merged commit 8bf9e53 into main Mar 25, 2026
45 checks passed
@TingDaoK TingDaoK deleted the on-remote-complete branch March 25, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants