add more comments

xiazhvera · xiazhvera · commit 4256aaa8eba0 · 2025-12-19T14:54:45.000-08:00
diff --git a/source/v5/mqtt5_options_storage.c b/source/v5/mqtt5_options_storage.c
@@ -3994,8 +3994,9 @@ struct aws_mqtt5_client_options_storage *aws_mqtt5_client_options_storage_new(
     }
 
     options_storage->connect = aws_mem_calloc(allocator, 1, sizeof(struct aws_mqtt5_packet_connect_storage));
+    // We pass in a NULL client option as we don't want to store extra metrics info in the connect storage here
     int connect_storage_result =
-        aws_mqtt5_packet_connect_storage_init(options_storage->connect, allocator, &connect_options, options);
+        aws_mqtt5_packet_connect_storage_init(options_storage->connect, allocator, &connect_options, NULL);
 
     aws_byte_buf_clean_up(&auto_assign_id_buf);
     if (connect_storage_result != AWS_OP_SUCCESS) {

Original file line number	Diff line number	Diff line change
`@@ -3994,8 +3994,9 @@ struct aws_mqtt5_client_options_storage *aws_mqtt5_client_options_storage_new(`
`3994`	`3994`	`}`
`3995`	`3995`
`3996`	`3996`	`options_storage->connect = aws_mem_calloc(allocator, 1, sizeof(struct aws_mqtt5_packet_connect_storage));`
	`3997`	`+ // We pass in a NULL client option as we don't want to store extra metrics info in the connect storage here`
`3997`	`3998`	`int connect_storage_result =`
`3998`		`- aws_mqtt5_packet_connect_storage_init(options_storage->connect, allocator, &connect_options, options);`
	`3999`	`+ aws_mqtt5_packet_connect_storage_init(options_storage->connect, allocator, &connect_options, NULL);`
`3999`	`4000`
`4000`	`4001`	`aws_byte_buf_clean_up(&auto_assign_id_buf);`
`4001`	`4002`	`if (connect_storage_result != AWS_OP_SUCCESS) {`