Skip to content

Commit 454d85b

Browse files
committed
fix clang
1 parent 535dcf8 commit 454d85b

4 files changed

Lines changed: 7 additions & 18 deletions

File tree

source/client_impl_shared.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ int aws_mqtt_iot_sdk_metrics_storage_init(
273273
struct aws_mqtt_iot_sdk_metrics *storage_view = &metrics_storage->storage_view;
274274

275275
// TODO: add metadata entries when enabled
276-
//
276+
//
277277
// if (aws_array_list_init_dynamic(
278278
// &metrics_storage->metadata_entries,
279279
// allocator,

tests/mqtt_iot_sdk_metrics_test.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,7 @@ static int s_test_mqtt_append_sdk_metrics_existing_attributes(struct aws_allocat
101101
static int s_test_mqtt_append_sdk_metrics_special_chars(struct aws_allocator *allocator, void *ctx) {
102102
(void)ctx;
103103

104-
struct aws_mqtt_iot_sdk_metrics metrics = {
105-
.library_name = aws_byte_cursor_from_c_str("SDK/Test-1.0")
106-
};
104+
struct aws_mqtt_iot_sdk_metrics metrics = {.library_name = aws_byte_cursor_from_c_str("SDK/Test-1.0")};
107105

108106
struct aws_byte_buf output_username;
109107
AWS_ZERO_STRUCT(output_username);
@@ -140,13 +138,9 @@ static int s_test_mqtt_append_sdk_metrics_long_strings(struct aws_allocator *all
140138
memset(long_sdk_name, 'B', sizeof(long_sdk_name) - 1);
141139
long_sdk_name[sizeof(long_sdk_name) - 1] = '\0';
142140

143-
struct aws_mqtt_iot_sdk_metrics metrics = {
144-
.library_name = aws_byte_cursor_from_c_str(long_sdk_name)
145-
};
141+
struct aws_mqtt_iot_sdk_metrics metrics = {.library_name = aws_byte_cursor_from_c_str(long_sdk_name)};
146142

147-
struct aws_mqtt_iot_sdk_metrics short_metrics = {
148-
.library_name = aws_byte_cursor_from_c_str("SHORT_SDK_NAME")
149-
};
143+
struct aws_mqtt_iot_sdk_metrics short_metrics = {.library_name = aws_byte_cursor_from_c_str("SHORT_SDK_NAME")};
150144

151145
struct aws_byte_buf output_username;
152146
AWS_ZERO_STRUCT(output_username);
@@ -171,9 +165,7 @@ static int s_test_mqtt_append_sdk_metrics_invalid_utf8(struct aws_allocator *all
171165
/* Invalid UTF-8 sequence in library name */
172166
struct aws_byte_cursor invalid_utf8_library = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("TestSDK\xFF\xFE");
173167

174-
struct aws_mqtt_iot_sdk_metrics metrics = {
175-
.library_name = invalid_utf8_library
176-
};
168+
struct aws_mqtt_iot_sdk_metrics metrics = {.library_name = invalid_utf8_library};
177169

178170
struct aws_byte_buf output_username;
179171
AWS_ZERO_STRUCT(output_username);

tests/v3/connection_state_test.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4116,9 +4116,7 @@ static int s_test_mqtt_connection_set_metrics_invalid_utf8_library_fn(struct aws
41164116
/* Invalid UTF-8 sequence */
41174117
struct aws_byte_cursor invalid_utf8_library = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("TestSDK\xFF\xFE");
41184118

4119-
struct aws_mqtt_iot_sdk_metrics metrics = {
4120-
.library_name = invalid_utf8_library
4121-
};
4119+
struct aws_mqtt_iot_sdk_metrics metrics = {.library_name = invalid_utf8_library};
41224120

41234121
ASSERT_FAILS(aws_mqtt_client_connection_set_metrics(state_test_data->mqtt_connection, &metrics));
41244122
ASSERT_INT_EQUALS(aws_last_error(), AWS_ERROR_INVALID_UTF8);

tests/v5/mqtt5_operation_validation_failure_tests.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1171,8 +1171,7 @@ static void s_make_invalid_connect_client_options(struct aws_mqtt5_client_option
11711171
AWS_CLIENT_CREATION_VALIDATION_FAILURE(invalid_connect, s_good_client_options, s_make_invalid_connect_client_options)
11721172

11731173
static struct aws_mqtt_iot_sdk_metrics invalid_utf8_metrics = {
1174-
.library_name = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("TestSDK\xFF\xFE")
1175-
};
1174+
.library_name = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("TestSDK\xFF\xFE")};
11761175

11771176
static struct aws_mqtt5_packet_connect_view s_invalid_utf8_metrics_connect_view = {.metrics = &invalid_utf8_metrics};
11781177
static void s_make_invalid_utf8_metrics(struct aws_mqtt5_client_options *options) {

0 commit comments

Comments
 (0)