Skip to content

Commit 5635561

Browse files
committed
verify regression test
1 parent 406a202 commit 5635561

5 files changed

Lines changed: 105 additions & 56 deletions

File tree

source/request-response/request_response_client.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ static void s_mqtt_request_response_client_final_destroy(struct aws_mqtt_request
319319
aws_mqtt_request_response_client_subscriptions_clean_up(&client->subscriptions);
320320
aws_hash_table_clean_up(&client->operations_by_correlation_tokens);
321321

322-
aws_event_loop_group_release_from_event_loop(client->loop);
322+
// aws_event_loop_group_release_from_event_loop(client->loop);
323323
aws_mem_release(client->allocator, client);
324324

325325
if (terminate_callback != NULL) {
@@ -1066,14 +1066,14 @@ static struct aws_mqtt_request_response_client *s_aws_mqtt_request_response_clie
10661066
rr_client->loop = loop;
10671067
// kept a reference to the event loop group to keep the event loop alive. It should be released when the client is
10681068
// destroyed.
1069-
if (!aws_event_loop_group_acquire_from_event_loop(loop)) {
1070-
aws_mem_release(allocator, rr_client);
1071-
AWS_LOGF_ERROR(
1072-
AWS_LS_MQTT_REQUEST_RESPONSE,
1073-
"(static) request response client creation failed - unable to acquire event loop group");
1074-
aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
1075-
return NULL;
1076-
}
1069+
// if (!aws_event_loop_group_acquire_from_event_loop(loop)) {
1070+
// aws_mem_release(allocator, rr_client);
1071+
// AWS_LOGF_ERROR(
1072+
// AWS_LS_MQTT_REQUEST_RESPONSE,
1073+
// "(static) request response client creation failed - unable to acquire event loop group");
1074+
// aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
1075+
// return NULL;
1076+
// }
10771077

10781078
aws_hash_table_init(
10791079
&rr_client->operations,

tests/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,7 @@ add_test_case(rrc_submit_request_operation_failure_by_shutdown)
551551
add_test_case(rrc_create_streaming_operation_and_shutdown)
552552
add_test_case(rrc_shutdown_and_activate_streaming_operation)
553553
add_test_case(rrc_activate_streaming_operation_and_shutdown)
554+
add_test_case(rrc_release_streaming_operation_after_client_shutdown)
554555
add_test_case(rrc_submit_request_operation_failure_by_timeout)
555556

556557
add_test_case(rrc_streaming_operation_success_single)

0 commit comments

Comments
 (0)