Skip to content

Commit 650ad30

Browse files
committed
fix double release
1 parent 3244647 commit 650ad30

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

source/client_impl_shared.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,11 @@ int aws_mqtt_iot_sdk_metrics_storage_init(
311311
return AWS_OP_SUCCESS;
312312

313313
metrics_storage_error:
314-
aws_mqtt_iot_sdk_metrics_storage_clean_up(metrics_storage);
314+
if (aws_array_list_is_valid(&metrics_storage->metadata_entries)) {
315+
aws_array_list_clean_up(&metrics_storage->metadata_entries);
316+
}
317+
aws_byte_buf_clean_up(&metrics_storage->storage);
318+
315319
return AWS_OP_ERR;
316320
}
317321

@@ -320,7 +324,9 @@ void aws_mqtt_iot_sdk_metrics_storage_clean_up(struct aws_mqtt_iot_sdk_metrics_s
320324
return;
321325
}
322326

323-
aws_array_list_clean_up(&metrics_storage->metadata_entries);
327+
if (aws_array_list_is_valid(&metrics_storage->metadata_entries)) {
328+
aws_array_list_clean_up(&metrics_storage->metadata_entries);
329+
}
324330
aws_byte_buf_clean_up(&metrics_storage->storage);
325331

326332
aws_mem_release(metrics_storage->allocator, &metrics_storage);

0 commit comments

Comments
 (0)