add success reuse of correlation token test

Author: sbSteveK

tests/CMakeLists.txt

@@ -581,6 +581,7 @@ add_test_case(rrc_request_response_failure_puback_reason_code)
 add_test_case(rrc_request_response_failure_invalid_payload)
 add_test_case(rrc_request_response_failure_missing_correlation_token)
 add_test_case(rrc_request_response_failure_duplicate_correlation_token)
+add_test_case(rrc_request_response_success_duplicate_correlation_token)
 add_test_case(rrc_request_response_failure_invalid_correlation_token_type)
 add_test_case(rrc_request_response_failure_non_matching_correlation_token)
 add_test_case(rrc_request_response_multi_operation_sequence)

tests/request-response/request_response_client_tests.c

@@ -3316,6 +3316,10 @@ AWS_TEST_CASE(
     rrc_request_response_failure_missing_correlation_token,
     s_rrc_request_response_failure_missing_correlation_token_fn)
 
+/*
+ * Use of a duplicate correlation token should result in a validation error at the point the request is submitted
+ * to the request response client.
+ */
 static int s_rrc_request_response_failure_duplicate_correlation_token_fn(struct aws_allocator *allocator, void *ctx) {
     (void)ctx;
 
@@ -3360,6 +3364,49 @@ AWS_TEST_CASE(
     rrc_request_response_failure_duplicate_correlation_token,
     s_rrc_request_response_failure_duplicate_correlation_token_fn)
 
+/*
+ * Reuse of a correlation token should be successful as long as the previous operation has completed.
+ */
+static int s_rrc_request_response_success_duplicate_correlation_token_fn(struct aws_allocator *allocator, void *ctx) {
+    (void)ctx;
+
+    aws_mqtt_library_init(allocator);
+
+    struct mqtt5_client_test_options client_test_options;
+    struct aws_rr_client_test_fixture fixture;
+    ASSERT_SUCCESS(s_init_fixture_request_operation_success(&fixture, &client_test_options, allocator, NULL, NULL));
+
+    struct aws_byte_cursor record_key = aws_byte_cursor_from_c_str("testkey");
+    ASSERT_SUCCESS(s_rrc_test_submit_test_request(
+        &fixture, RRC_PHDT_SUCCESS, "test", record_key, "test/accepted", "token1", NULL, false));
+
+    s_rrc_wait_on_request_completion(&fixture, record_key);
+
+    struct aws_byte_cursor expected_response_topic = aws_byte_cursor_from_c_str("test/accepted");
+    struct aws_byte_cursor expected_payload = aws_byte_cursor_from_c_str("{\"token\":\"token1\"}");
+    ASSERT_SUCCESS(s_rrc_verify_request_completion(
+        &fixture, record_key, AWS_ERROR_SUCCESS, &expected_response_topic, &expected_payload));
+
+    struct aws_byte_cursor record_key_2 = aws_byte_cursor_from_c_str("testkey2");
+    ASSERT_SUCCESS(s_rrc_test_submit_test_request(
+        &fixture, RRC_PHDT_SUCCESS, "test", record_key_2, "test/accepted", "token1", NULL, false));
+
+    s_rrc_wait_on_request_completion(&fixture, record_key_2);
+
+    ASSERT_SUCCESS(s_rrc_verify_request_completion(
+        &fixture, record_key_2, AWS_ERROR_SUCCESS, &expected_response_topic, &expected_payload));
+
+    s_aws_rr_client_test_fixture_clean_up(&fixture, false);
+
+    aws_mqtt_library_clean_up();
+
+    return AWS_OP_SUCCESS;
+}
+
+AWS_TEST_CASE(
+    rrc_request_response_success_duplicate_correlation_token,
+    s_rrc_request_response_success_duplicate_correlation_token_fn)
+
 static int s_rrc_request_response_failure_invalid_correlation_token_type_fn(
     struct aws_allocator *allocator,
     void *ctx) {