Skip to content

Commit ad011fe

Browse files
committed
update client option storage for metrics
1 parent c47e142 commit ad011fe

3 files changed

Lines changed: 8 additions & 3 deletions

File tree

include/aws/mqtt/private/v5/mqtt5_options_storage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ struct aws_mqtt5_client_options_storage {
184184

185185
struct aws_host_resolution_config host_resolution_override;
186186

187-
const struct aws_mqtt_iot_sdk_metrics *metrics;
187+
struct aws_mqtt_iot_sdk_metrics_storage *metrics_storage;
188188
};
189189

190190
AWS_EXTERN_C_BEGIN

source/v5/mqtt5_options_storage.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3778,6 +3778,10 @@ void aws_mqtt5_client_options_storage_destroy(struct aws_mqtt5_client_options_st
37783778
aws_mem_release(options_storage->connect->allocator, options_storage->connect);
37793779
}
37803780

3781+
if (options_storage->metrics_storage != NULL) {
3782+
aws_mqtt_iot_sdk_metrics_storage_destroy(options_storage->metrics_storage);
3783+
}
3784+
37813785
aws_mem_release(options_storage->allocator, options_storage);
37823786
}
37833787

@@ -4022,8 +4026,8 @@ struct aws_mqtt5_client_options_storage *aws_mqtt5_client_options_storage_new(
40224026
options_view->host_resolution_override = &options_storage->host_resolution_override;
40234027

40244028
// TODO: Placehold for metrics storage implemnetation.
4025-
// options_storage->metrics = options->metrics;
4026-
// options_view->metrics = options_storage->metrics;
4029+
options_storage->metrics_storage = aws_mqtt_iot_sdk_metrics_storage_new(allocator, options->metrics);
4030+
options_view->metrics = &options_storage->metrics_storage->storage_view;
40274031

40284032
return options_storage;
40294033

tests/v5/mqtt5_operation_and_storage_tests.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
#include <aws/mqtt/mqtt.h>
1515
#include <aws/mqtt/private/v5/mqtt5_options_storage.h>
1616
#include <aws/mqtt/private/v5/mqtt5_utils.h>
17+
#include <aws/mqtt/v5/mqtt5_client.h>
1718
#include <aws/mqtt/v5/mqtt5_types.h>
1819

1920
#include <aws/testing/aws_test_harness.h>

0 commit comments

Comments
 (0)