address comments

Author: TingDaoK

include/aws/s3/private/s3_checksum_context.h

@@ -111,7 +111,7 @@ bool aws_s3_upload_request_checksum_context_should_add_header(
     const struct aws_s3_upload_request_checksum_context *context);
 
 /**
- * Check if checksum should be added as trailer (chunked encoding).
+ * Check if checksum should be added as trailer (aws-chunked encoding).
  * Returns true if the context has a valid algorithm and the location is set to trailer.
  *
  * @param context The checksum context to check
@@ -133,7 +133,7 @@ struct aws_byte_buf *aws_s3_upload_request_checksum_context_get_output_buffer(
     struct aws_s3_upload_request_checksum_context *context);
 
 /**
- * Get a cursor to the current checksum value (for use in headers/trailers).
+ * Get a cursor to the current base64 encoded checksum value (for use in headers/trailers).
  * Returns an empty cursor if the checksum has not been calculated yet.
  *
  * @param context The checksum context

include/aws/s3/private/s3_checksums.h

@@ -87,31 +87,27 @@ struct aws_input_stream *aws_checksum_stream_new(
  * Creates a chunked encoding stream that wraps an existing stream and adds checksum trailers.
  *
  * This function creates a stream that:
- * 1. Encodes the input stream using HTTP chunked transfer encoding
+ * 1. Encodes the input stream wraps the existing_stream with aws-chunked encoded.
  * 2. Calculates a checksum of the stream content (if not already calculated)
- * 3. Appends the checksum as a trailer at the end of the chunked stream
- *
- * The output format follows HTTP chunked encoding with checksum trailers:
- * - For non-empty streams: [hex-length]\r\n[data]\r\n0\r\n[checksum-header]:[checksum-value]\r\n\r\n
- * - For empty streams: 0\r\n[checksum-header]:[checksum-value]\r\n\r\n
+ * 3. Appends the checksum as a trailer at the end of the aws-chunked stream
  *
  * Note: This stream does not support seeking operations, as seeking would prevent
  * accurate checksum calculation and corrupt the chunked encoding format.
  *
- * @param allocator Memory allocator to use for stream creation and internal buffers
- * @param existing_stream The input stream to be chunked and checksummed. This stream
- *                       will be acquired by the chunk stream and released when the
- *                       chunk stream is destroyed. Must not be NULL.
- * @param checksum_context Context containing checksum configuration and state. Must not be NULL.
- *                        The context contains:
- *                        - algorithm: The checksum algorithm to use (CRC32, CRC32C, etc.)
- *                        - base64_checksum: Buffer for the calculated checksum result
- *                        - checksum_calculated: Whether checksum is pre-calculated or needs calculation
- *                        - encoded_checksum_size: Expected size of the base64-encoded checksum
+ * @param allocator         Memory allocator to use for stream creation and internal buffers
+ * @param existing_stream   The input stream to be chunked and checksummed. This stream
+ *                          will be acquired by the chunk stream and released when the
+ *                          chunk stream is destroyed. Must not be NULL.
+ * @param checksum_context  Context containing checksum configuration and state. Must not be NULL.
+ *                          The context contains:
+ *                          - algorithm: The checksum algorithm to use (CRC32, CRC32C, etc.)
+ *                          - base64_checksum: Buffer for the calculated checksum result
+ *                          - checksum_calculated: Whether checksum is pre-calculated or needs calculation
+ *                          - encoded_checksum_size: Expected size of the base64-encoded checksum
  *
- *                        If checksum_calculated is false, the stream will wrap existing_stream
- *                        with a checksum stream to calculate the checksum during reading.
- *                        If checksum_calculated is true, the existing checksum value will be used.
+ *                          If checksum_calculated is false, the stream will wrap existing_stream
+ *                          with a checksum stream to calculate the checksum during reading.
+ *                          If checksum_calculated is true, the existing checksum value will be used.
  *
  * @return A new input stream that provides chunked encoding with checksum trailers,
  *         or NULL if creation fails. The returned stream must be released with

source/s3_auto_ranged_put.c

@@ -161,7 +161,7 @@ static int s_process_part_info_synced(const struct aws_s3_part_info *info, void
         part->checksum_context = aws_s3_upload_request_checksum_context_new(
             auto_ranged_put->base.allocator, &auto_ranged_put->base.checksum_config);
     }
-    if (!part->checksum_context) {
+    if (part->checksum_context == NULL) {
         aws_mem_release(meta_request->allocator, part);
         return AWS_OP_ERR;
     }