Add user data to pool factory (#529)

Author: DmitriyMusatkin

include/aws/s3/s3_buffer_pool.h

@@ -141,7 +141,8 @@ struct aws_s3_buffer_pool_config {
  * by logging failure reason, returning null and raising aws_error.
  */
 typedef struct aws_s3_buffer_pool *(aws_s3_buffer_pool_factory_fn)(struct aws_allocator *allocator,
-                                                                   struct aws_s3_buffer_pool_config config);
+                                                                   struct aws_s3_buffer_pool_config config,
+                                                                   void *user_data);
 
 AWS_EXTERN_C_END
 AWS_POP_SANE_WARNING_LEVEL

include/aws/s3/s3_client.h

@@ -606,6 +606,9 @@ struct aws_s3_client_config {
      * if not set creates default implementation of the buffer pool.
      */
     aws_s3_buffer_pool_factory_fn *buffer_pool_factory_fn;
+
+    /* User data thats passed into pool factory. */
+    void *buffer_pool_user_data;
 };
 
 struct aws_s3_checksum_config {

source/s3_client.c

@@ -367,7 +367,8 @@ struct aws_s3_client *aws_s3_client_new(
     };
 
     if (client_config->buffer_pool_factory_fn) {
-        client->buffer_pool = client_config->buffer_pool_factory_fn(allocator, buffer_pool_config);
+        client->buffer_pool =
+            client_config->buffer_pool_factory_fn(allocator, buffer_pool_config, client_config->buffer_pool_user_data);
     } else {
 
         client->buffer_pool = aws_s3_default_buffer_pool_new(allocator, buffer_pool_config);

tests/s3_data_plane_tests.c

@@ -3375,8 +3375,10 @@ void s_failing_pool_destroy(struct aws_s3_buffer_pool *buffer_pool_wrapper) {
 
 struct aws_s3_buffer_pool *s_always_error_buffer_pool_fn(
     struct aws_allocator *allocator,
-    struct aws_s3_buffer_pool_config config) {
+    struct aws_s3_buffer_pool_config config,
+    void *user_data) {
     (void)config;
+    (void)user_data;
     struct aws_s3_buffer_pool *pool = aws_mem_calloc(allocator, 1, sizeof(struct aws_s3_buffer_pool));
     pool->impl = allocator;
     pool->vtable = &s_failing_pool_vtable;