lint changes

Author: Krish

include/aws/s3/private/s3_request.h

@@ -44,8 +44,8 @@ struct aws_s3_request_metrics {
 
         /* The total time duration for the complete request lifecycle from initial start to final completion,
          * including all retry attempts, backoff delays, and connection establishment time
-         * (s3_request_last_attempt_end_timestamp_ns - s3_request_first_attempt_start_timestamp_ns). This represents the end-to-end user
-         * experience time. This will be available with the last attempt. */
+         * (s3_request_last_attempt_end_timestamp_ns - s3_request_first_attempt_start_timestamp_ns). This represents the
+         * end-to-end user experience time. This will be available with the last attempt. */
         int64_t s3_request_total_duration_ns;
 
         /* The time stamp when the request started by S3 client, which is prepared time by the client. Timestamps

source/s3_client.c

@@ -2462,8 +2462,7 @@ void aws_s3_client_notify_connection_finished(
         }
 
         /* Ask the retry strategy to schedule a retry of the request. */
-        aws_high_res_clock_get_ticks(
-            (uint64_t *)&request->retry_start_timestamp_ns);
+        aws_high_res_clock_get_ticks((uint64_t *)&request->retry_start_timestamp_ns);
         if (aws_retry_strategy_schedule_retry(
                 connection->retry_token, error_type, s_s3_client_retry_ready, connection)) {
 
@@ -2485,8 +2484,11 @@ void aws_s3_client_notify_connection_finished(
 
 reset_connection:
 
-    aws_high_res_clock_get_ticks((uint64_t *)&request->send_data.metrics->time_metrics.s3_request_last_attempt_end_timestamp_ns);
-    request->send_data.metrics->time_metrics.s3_request_total_duration_ns = request->send_data.metrics->time_metrics.s3_request_last_attempt_end_timestamp_ns - request->send_data.metrics->time_metrics.s3_request_first_attempt_start_timestamp_ns;
+    aws_high_res_clock_get_ticks(
+        (uint64_t *)&request->send_data.metrics->time_metrics.s3_request_last_attempt_end_timestamp_ns);
+    request->send_data.metrics->time_metrics.s3_request_total_duration_ns =
+        request->send_data.metrics->time_metrics.s3_request_last_attempt_end_timestamp_ns -
+        request->send_data.metrics->time_metrics.s3_request_first_attempt_start_timestamp_ns;
 
     if (connection->retry_token != NULL) {
         /* If we have a retry token and successfully finished, record that success. */

source/s3_meta_request.c

@@ -1518,10 +1518,10 @@ static void s_s3_meta_request_stream_metrics(
     s3_metrics->time_metrics.send_end_timestamp_ns = http_metrics->send_end_timestamp_ns;
     s3_metrics->time_metrics.sending_duration_ns = http_metrics->sending_duration_ns;
     s3_metrics->time_metrics.receive_start_timestamp_ns = http_metrics->receive_start_timestamp_ns;
-    
+
     if (s3_metrics->time_metrics.receive_start_timestamp_ns != -1) {
-        s3_metrics->time_metrics.service_call_duration_ns =
-            s3_metrics->time_metrics.receive_start_timestamp_ns - s3_metrics->time_metrics.conn_acquire_start_timestamp_ns;
+        s3_metrics->time_metrics.service_call_duration_ns = s3_metrics->time_metrics.receive_start_timestamp_ns -
+                                                            s3_metrics->time_metrics.conn_acquire_start_timestamp_ns;
     }
 
     s3_metrics->time_metrics.receive_end_timestamp_ns = http_metrics->receive_end_timestamp_ns;

source/s3_request.c

@@ -121,7 +121,8 @@ void aws_s3_request_setup_send_data(struct aws_s3_request *request, struct aws_h
 
         // metrics persisted to the next request
         request->send_data.metrics->crt_info_metrics.retry_attempt = request->num_times_prepared;
-        request->send_data.metrics->time_metrics.s3_request_first_attempt_start_timestamp_ns = first_attempt_start_timestamp_ns;
+        request->send_data.metrics->time_metrics.s3_request_first_attempt_start_timestamp_ns =
+            first_attempt_start_timestamp_ns;
     }
 
     request->send_data.message = message;

tests/s3_mock_server_tests.c

@@ -144,7 +144,7 @@ static int s_validate_create_multipart_upload_metrics(struct aws_s3_request_metr
     ASSERT_UINT_EQUALS(AWS_ERROR_SUCCESS, aws_s3_request_metrics_get_error_code(metrics));
 
     /* Get all those time stamp */
-    ASSERT_SUCCESS(s_validate_time_metrics(metrics, true));    
+    ASSERT_SUCCESS(s_validate_time_metrics(metrics, true));
 
     enum aws_s3_request_type request_type = 0;
     aws_s3_request_metrics_get_request_type(metrics, &request_type);
@@ -176,7 +176,7 @@ static int s_validate_upload_part_metrics(struct aws_s3_request_metrics *metrics
     ASSERT_SUCCESS(aws_s3_request_metrics_get_operation_name(metrics, &operation_name));
     ASSERT_STR_EQUALS("UploadPart", aws_string_c_str(operation_name));
 
-    ASSERT_SUCCESS(s_validate_time_metrics(metrics, is_last_attempt));   
+    ASSERT_SUCCESS(s_validate_time_metrics(metrics, is_last_attempt));
 
     return AWS_OP_SUCCESS;
 }
@@ -231,18 +231,19 @@ static int s_validate_retry_metrics(
     aws_array_list_get_at(metrics_list, (void **)&metrics, 0);
     ASSERT_SUCCESS(s_validate_create_multipart_upload_metrics(metrics));
 
-
     /* All of the middle should be Upload Parts*/
     size_t failed_count = 0;
-    for(size_t i = 1; i < aws_array_list_length(metrics_list) - 1; i = i + expected_failures + 1){
+    for (size_t i = 1; i < aws_array_list_length(metrics_list) - 1; i = i + expected_failures + 1) {
         aws_array_list_get_at(metrics_list, &metrics, i);
-        for(size_t j = i; j < i + expected_failures; j++){
-            aws_array_list_get_at(metrics_list, &metrics2, j+1);
+        for (size_t j = i; j < i + expected_failures; j++) {
+            aws_array_list_get_at(metrics_list, &metrics2, j + 1);
             ASSERT_TRUE(metrics->crt_info_metrics.error_code != AWS_ERROR_SUCCESS);
             failed_count++;
             aws_array_list_get_at(metrics_list, (void **)&metrics, j);
             ASSERT_SUCCESS(s_validate_upload_part_metrics(metrics, false));
-            ASSERT_INT_EQUALS(metrics->time_metrics.s3_request_first_attempt_start_timestamp_ns, metrics2->time_metrics.s3_request_first_attempt_start_timestamp_ns);
+            ASSERT_INT_EQUALS(
+                metrics->time_metrics.s3_request_first_attempt_start_timestamp_ns,
+                metrics2->time_metrics.s3_request_first_attempt_start_timestamp_ns);
             ASSERT_INT_EQUALS(metrics->crt_info_metrics.retry_attempt + 1, metrics2->crt_info_metrics.retry_attempt);
             metrics = metrics2;
         }