Skip to content

Commit 82798df

Browse files
more test fixes
1 parent 274f143 commit 82798df

2 files changed

Lines changed: 14 additions & 4 deletions

File tree

tests/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@ add_net_test_case(test_s3_range_requests_less_than_a_part)
243243
add_net_test_case(test_s3_not_satisfiable_range)
244244
add_net_test_case(test_s3_invalid_start_range_greator_than_end_range)
245245
add_net_test_case(test_s3_empty_file_edge_case)
246-
add_net_test_case(test_s3_default_put_object_checksum)
247246

248247
add_net_test_case(test_s3_bad_endpoint)
249248
add_net_test_case(test_s3_different_endpoints)

tests/s3_checksum_context_test.c

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,17 +94,28 @@ static int s_test_upload_request_checksum_context_error_cases(struct aws_allocat
9494
.location = AWS_SCL_NONE,
9595
.has_full_object_checksum = false,
9696
};
97-
ASSERT_FALSE(aws_s3_upload_request_checksum_context_should_calculate(&config2));
97+
struct aws_s3_upload_request_checksum_context *context2 =
98+
aws_s3_upload_request_checksum_context_new(allocator, &config2);
99+
100+
ASSERT_NOT_NULL(context2);
101+
ASSERT_FALSE(aws_s3_upload_request_checksum_context_should_calculate(context2));
98102

99103
/* unknown algo */
100-
struct aws_s3_meta_request_checksum_config_storage config2 = {
104+
struct aws_s3_meta_request_checksum_config_storage config3 = {
101105
.allocator = allocator,
102106
.checksum_algorithm = AWS_SCA_CRC32,
103107
.location = AWS_SCL_NONE,
104108
.has_full_object_checksum = false,
105109
.full_object_checksum_callback = s_test_fn,
106110
};
107-
ASSERT_FALSE(aws_s3_upload_request_checksum_context_should_calculate(&config2));
111+
struct aws_s3_upload_request_checksum_context *context3 =
112+
aws_s3_upload_request_checksum_context_new(allocator, &config3);
113+
114+
ASSERT_NOT_NULL(context3);
115+
ASSERT_FALSE(aws_s3_upload_request_checksum_context_should_calculate(context3));
116+
117+
aws_s3_upload_request_checksum_context_release(context2);
118+
aws_s3_upload_request_checksum_context_release(context3);
108119

109120
return AWS_OP_SUCCESS;
110121
}

0 commit comments

Comments
 (0)