init copy default signing config (#185)

* internalize signed body value

Author: ilevyor

source/s3_meta_request.c

@@ -610,6 +610,15 @@ static void s_s3_meta_request_sign_request(
     meta_request->vtable->sign_request(meta_request, request, on_signing_complete, user_data);
 }
 
+static bool s_is_put_request(const struct aws_s3_meta_request *meta_request) {
+    struct aws_byte_cursor method;
+    if (meta_request->type == AWS_S3_META_REQUEST_TYPE_DEFAULT &&
+        !aws_http_message_get_request_method(meta_request->initial_request_message, &method)) {
+        return aws_byte_cursor_eq(&method, &aws_http_method_put);
+    }
+    return meta_request->type == AWS_S3_META_REQUEST_TYPE_PUT_OBJECT;
+}
+
 /* Handles signing a message for the caller. */
 void aws_s3_meta_request_sign_request_default(
     struct aws_s3_meta_request *meta_request,
@@ -663,6 +672,14 @@ void aws_s3_meta_request_sign_request_default(
         return;
     }
 
+    /* if a checksum algorithm is set for a put request the request will be chunked and we need to change the signed
+     * body value to match this type of request*/
+    if (meta_request->checksum_algorithm != AWS_SCA_NONE && s_is_put_request(meta_request) &&
+        aws_byte_cursor_eq(&signing_config.signed_body_value, &g_aws_signed_body_value_unsigned_payload)) {
+        signing_config.signed_body_value = g_aws_signed_body_value_streaming_unsigned_payload_trailer;
+    }
+    /* However the initial request for a multipart upload does not have a trailing checksum and is not chunked so it
+     * must have an unsigned_payload signed_body value*/
     if (request->part_number == 0 &&
         aws_byte_cursor_eq(
             &signing_config.signed_body_value, &g_aws_signed_body_value_streaming_unsigned_payload_trailer)) {

tests/s3_cancel_tests.c

@@ -175,7 +175,7 @@ static int s3_cancel_test_helper(struct aws_allocator *allocator, enum s3_update
     AWS_ASSERT(allocator);
 
     struct aws_s3_tester tester;
-    ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester, false));
+    ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester));
 
     struct s3_cancel_test_user_data test_user_data = {
         .type = cancel_type,
@@ -285,7 +285,7 @@ static int s3_cancel_test_helper_fc(
     AWS_ASSERT(allocator);
 
     struct aws_s3_tester tester;
-    ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester, true));
+    ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester));
 
     struct s3_cancel_test_user_data test_user_data = {
         .type = cancel_type,
@@ -346,14 +346,9 @@ static int s3_cancel_test_helper_fc(
         // Range for the second 16k
         const struct aws_byte_cursor range = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("bytes=16384-32767");
 
-        struct aws_signing_config_aws get_signing_config;
-
-        aws_s3_init_default_signing_config(&get_signing_config, g_test_s3_region, tester.credentials_provider);
-
         struct aws_s3_tester_meta_request_options options = {
             .allocator = allocator,
             .client = client,
-            .signing_config = &get_signing_config,
             .validate_get_response_checksum = true,
             .meta_request_type = AWS_S3_META_REQUEST_TYPE_GET_OBJECT,
             .validate_type = AWS_S3_TESTER_VALIDATE_TYPE_EXPECT_FAILURE,
@@ -590,7 +585,7 @@ static int s_test_s3_cancel_prepare(struct aws_allocator *allocator, void *ctx)
     (void)ctx;
 
     struct aws_s3_tester tester;
-    ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester, false));
+    ASSERT_SUCCESS(aws_s3_tester_init(allocator, &tester));
 
     struct test_s3_cancel_prepare_user_data test_user_data;
     AWS_ZERO_STRUCT(test_user_data);