Skip to content

Commit 977815f

Browse files
authored
Fixing ref count bug related to streaming requests (#89)
1 parent f732c85 commit 977815f

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

source/s3_meta_request.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -987,11 +987,12 @@ void aws_s3_meta_request_finish_default(struct aws_s3_meta_request *meta_request
987987
meta_request->synced_data.client = NULL;
988988

989989
/* Clean out the pending-stream-to-caller priority queue*/
990-
struct aws_s3_request *request = aws_s3_meta_request_body_streaming_pop_synced(meta_request);
990+
while (aws_priority_queue_size(&meta_request->synced_data.pending_body_streaming_requests) > 0) {
991+
struct aws_s3_request *request = NULL;
992+
aws_priority_queue_pop(&meta_request->synced_data.pending_body_streaming_requests, (void **)&request);
993+
AWS_FATAL_ASSERT(request != NULL);
991994

992-
while (request != NULL) {
993995
aws_linked_list_push_back(&release_request_list, &request->node);
994-
request = aws_s3_meta_request_body_streaming_pop_synced(meta_request);
995996
}
996997

997998
finish_result = meta_request->synced_data.finish_result;

0 commit comments

Comments
 (0)