Skip to content

Commit c27e829

Browse files
change stale issue and discussion handling to run once a week (#541)
1 parent 36e2c37 commit c27e829

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

.github/workflows/handle-stale-discussions.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: HandleStaleDiscussions
22
on:
33
schedule:
4-
- cron: '0 */4 * * *'
4+
- cron: "0 9 * * 1"
55
discussion_comment:
66
types: [created]
77

@@ -15,4 +15,4 @@ jobs:
1515
- name: Stale discussions action
1616
uses: aws-github-ops/handle-stale-discussions@v1
1717
env:
18-
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
18+
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

.github/workflows/stale_issue.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: "Close stale issues"
33
# Controls when the action will run.
44
on:
55
schedule:
6-
- cron: "*/60 * * * *"
6+
- cron: "0 9 * * 1"
77

88
jobs:
99
cleanup:

source/s3_checksum_stream.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,19 @@ static int s_finalize_checksum(struct aws_checksum_stream *impl) {
3535
return aws_raise_error(AWS_ERROR_S3_CHECKSUM_CALCULATION_FAILED);
3636
}
3737
struct aws_byte_cursor checksum_result_cursor = aws_byte_cursor_from_buf(&impl->checksum_result);
38-
AWS_FATAL_ASSERT(aws_base64_encode(&checksum_result_cursor, impl->encoded_checksum_output) == AWS_OP_SUCCESS);
38+
if (aws_base64_encode(&checksum_result_cursor, impl->encoded_checksum_output) != AWS_OP_SUCCESS) {
39+
AWS_LOGF_ERROR(
40+
AWS_LS_S3_CLIENT,
41+
"Failed to base64 encode checksum with error code %d (%s). Output capacity: %zu length %zu",
42+
aws_last_error(),
43+
aws_error_str(aws_last_error()),
44+
impl->encoded_checksum_output->capacity,
45+
impl->encoded_checksum_output->len);
46+
aws_byte_buf_reset(&impl->checksum_result, true);
47+
impl->checksum_finalized = true;
48+
return aws_raise_error(AWS_ERROR_S3_CHECKSUM_CALCULATION_FAILED);
49+
}
50+
3951
impl->checksum_finalized = true;
4052
return AWS_OP_SUCCESS;
4153
}

0 commit comments

Comments
 (0)