Skip to content

Commit d8ad711

Browse files
committed
renaming helper and add some descriptions
1 parent 1ab4fef commit d8ad711

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

source/s3_meta_request.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1985,14 +1985,17 @@ static struct aws_s3_request_metrics *s_s3_request_finish_up_and_release_metrics
19851985
return NULL;
19861986
}
19871987

1988-
static bool s_apply_backpressure(struct aws_s3_request *request) {
1988+
static bool s_should_apply_backpressure(struct aws_s3_request *request) {
19891989
struct aws_s3_meta_request *meta_request = request->meta_request;
1990-
if (!meta_request->body_callback) {
1990+
if (!meta_request->client->enable_read_backpressure) {
1991+
/* Backpressure is disabled. */
19911992
return false;
19921993
}
1993-
if (!meta_request->client->enable_read_backpressure) {
1994+
if (!meta_request->body_callback) {
1995+
/* No callback to deliver the body, don't apply backpressure */
19941996
return false;
19951997
}
1998+
/* Apply backpressure only for GetObject request */
19961999
if (meta_request->type == AWS_S3_META_REQUEST_TYPE_GET_OBJECT) {
19972000
return true;
19982001
}
@@ -2076,7 +2079,7 @@ static void s_s3_meta_request_event_delivery_task(struct aws_task *task, void *a
20762079
break;
20772080
}
20782081

2079-
if (s_apply_backpressure(request)) {
2082+
if (s_should_apply_backpressure(request)) {
20802083
/* Apply backpressure for the request, only deliver the bytes that allowed to deliver. */
20812084
aws_byte_cursor_advance(&response_body, bytes_delivered_for_request);
20822085
if (response_body.len > (size_t)bytes_allowed_to_deliver) {

0 commit comments

Comments
 (0)