Skip to content

Commit fb3b302

Browse files
committed
address comments
1 parent dbbef99 commit fb3b302

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

include/aws/s3/s3_client.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,8 +606,8 @@ struct aws_s3_client_config {
606606
*
607607
* WARNING: This feature is experimental.
608608
* Currently, backpressure is only applied to GetObject requests which are split into multiple parts,
609-
* - you may still receive some data after the window reaches 0 for body_callback_ex.
610609
* - If you set body_callback, no more data will be delivered once the window reaches 0.
610+
* - If you set body_callback_ex, you may still receive some data after the window reaches 0. TODO: fix it.
611611
*/
612612
bool enable_read_backpressure;
613613

@@ -1221,8 +1221,8 @@ struct aws_future_void *aws_s3_meta_request_write(
12211221
*
12221222
* WARNING: This feature is experimental.
12231223
* Currently, backpressure is only applied to GetObject requests which are split into multiple parts,
1224-
* - you may still receive some data after the window reaches 0 for body_callback_ex.
12251224
* - If you set body_callback, no more data will be delivered once the window reaches 0.
1225+
* - If you set body_callback_ex, you may still receive some data after the window reaches 0. TODO: fix it.
12261226
*/
12271227
AWS_S3_API
12281228
void aws_s3_meta_request_increment_read_window(struct aws_s3_meta_request *meta_request, uint64_t bytes);

source/s3_meta_request.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ void aws_s3_meta_request_increment_read_window(struct aws_s3_meta_request *meta_
412412
/* Response will never approach UINT64_MAX, so do a saturating sum instead of worrying about overflow */
413413
meta_request->synced_data.read_window_running_total =
414414
aws_add_u64_saturating(bytes, meta_request->synced_data.read_window_running_total);
415-
/* Kick off the event delivery task again see if we need to */
415+
/* Try to schedule the delivery task again. */
416416
aws_s3_meta_request_add_event_for_delivery_synced(meta_request, NULL);
417417

418418
aws_s3_meta_request_unlock_synced_data(meta_request);
@@ -1888,7 +1888,7 @@ void aws_s3_meta_request_add_event_for_delivery_synced(
18881888
aws_array_list_push_back(&meta_request->synced_data.event_delivery_array, event);
18891889
}
18901890

1891-
/* If the event delivery task is not scheduled before, and there are more to be delivery. */
1891+
/* If the event delivery task is not scheduled before, and there are more to be delivered. */
18921892
if (!meta_request->synced_data.event_delivery_task_scheduled &&
18931893
aws_array_list_length(&meta_request->synced_data.event_delivery_array) > 0) {
18941894
aws_s3_meta_request_acquire(meta_request);

0 commit comments

Comments
 (0)