fix unknown checksum handling#633
Merged
Merged
Conversation
TingDaoK
reviewed
May 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 88.96% 88.98% +0.01%
==========================================
Files 23 23
Lines 7759 7769 +10
==========================================
+ Hits 6903 6913 +10
Misses 856 856
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Before this pr sending default request with a body that had any header starting with "x-amz-checksum-" that was not a valid checksum would fail with a generic error about failing to asign the body. Ex. completeMPU call going through default that had a body and x-amz-checksum-type header. Note: this is manual call to completeMPU though default meta request and usual flow is not affected.
2 changes made in this pr to mitigate the issue:
Note: there is still a weird case that if checksum is provided for default with body and there is a verification callback, then we recompute checksum. on one side it makes sense to recompute on the other it does not. so leaving as is for now
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.