address feedback

Author: DmitriyMusatkin

include/aws/checksums/private/crc_util.h

@@ -89,7 +89,7 @@ extern bool s_detected_avx512;
 extern bool s_detected_clmul;
 extern bool s_detected_vpclmulqdq;
 
-static inline void s_init_detection_cache(void) {
+static inline void aws_init_detection_cache(void) {
     s_detected_clmul = aws_cpu_has_feature(AWS_CPU_FEATURE_CLMUL);
     s_detected_sse42 = aws_cpu_has_feature(AWS_CPU_FEATURE_SSE_4_2);
     s_detected_avx512 = aws_cpu_has_feature(AWS_CPU_FEATURE_AVX512);
@@ -99,28 +99,28 @@ static inline void s_init_detection_cache(void) {
 
 static inline bool aws_cpu_has_clmul_cached(void) {
     if (AWS_UNLIKELY(!s_detection_performed)) {
-        s_init_detection_cache();
+        aws_init_detection_cache();
     }
     return s_detected_clmul;
 }
 
 static inline bool aws_cpu_has_sse42_cached(void) {
     if (AWS_UNLIKELY(!s_detection_performed)) {
-        s_init_detection_cache();
+        aws_init_detection_cache();
     }
     return s_detected_sse42;
 }
 
 static inline bool aws_cpu_has_avx512_cached(void) {
     if (AWS_UNLIKELY(!s_detection_performed)) {
-        s_init_detection_cache();
+        aws_init_detection_cache();
     }
     return s_detected_avx512;
 }
 
 static inline bool aws_cpu_has_vpclmulqdq_cached(void) {
     if (AWS_UNLIKELY(!s_detection_performed)) {
-        s_init_detection_cache();
+        aws_init_detection_cache();
     }
     return s_detected_vpclmulqdq;
 }

source/checksums.c

@@ -20,7 +20,7 @@ void aws_checksums_library_init(struct aws_allocator *allocator) {
 
         aws_common_library_init(allocator);
 
-        (void)aws_cpu_has_clmul_cached(); /* warm up the cache */
+        aws_init_detection_cache();
         aws_checksums_crc32_init();
         aws_checksums_crc64_init();
     }