Skip to content

Commit 16dd720

Browse files
author
Krish
committed
update doc
1 parent 34add6a commit 16dd720

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

builder/actions/cmake.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,12 @@ def _build_project(env, project, cmake_extra, build_tests=False, args_transforme
197197

198198
working_dir = env.root_dir if toolchain.cross_compile else os.getcwd()
199199

200+
# Previous use of UniqueList did not allow multiple appends to the list of the same key value pair.
201+
# Adding a new method 'unique_flags' which allows all args to be appended, but in the final set, we remove
202+
# multiple declarations of certain flags keeping the last occurrence.
203+
# CMake inherently supports multiple arguments and traverses from left to right and constantly updates the
204+
# flag value based on latest read. However, windows does not support some flags being duplicated ('-A'
205+
# or '-T') which would cause windows CI to fail.
200206
cmake_args = unique_flags(cmake_args, '-A', '-T')
201207

202208
# configure

0 commit comments

Comments
 (0)