Skip to content

Commit 4934962

Browse files
author
Bret Ambrose
committed
Use default bootstrap to avoid scope destruction issue
1 parent 1607038 commit 4934962

File tree

1 file changed

+3
-33
lines changed

1 file changed

+3
-33
lines changed

tests/Mqtt5ClientTest.cpp

Lines changed: 3 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,6 @@ static int s_TestMqtt5NewClientFull(Aws::Crt::Allocator *allocator, void *)
8383
Aws::Crt::Io::SocketOptions socketOptions;
8484
socketOptions.SetConnectTimeoutMs(3000);
8585

86-
Aws::Crt::Io::EventLoopGroup eventLoopGroup(0, allocator);
87-
ASSERT_TRUE(eventLoopGroup);
88-
89-
Aws::Crt::Io::DefaultHostResolver defaultHostResolver(eventLoopGroup, 8, 30, allocator);
90-
ASSERT_TRUE(defaultHostResolver);
91-
92-
Aws::Crt::Io::ClientBootstrap clientBootstrap(eventLoopGroup, defaultHostResolver, allocator);
93-
ASSERT_TRUE(allocator);
94-
clientBootstrap.EnableBlockingShutdown();
95-
9686
// Setup will
9787
const Aws::Crt::String TEST_TOPIC = "test/MQTT5_Binding_CPP/s_TestMqtt5NewClientFull";
9888
ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test");
@@ -118,7 +108,7 @@ static int s_TestMqtt5NewClientFull(Aws::Crt::Allocator *allocator, void *)
118108
Mqtt5::JitterMode::AWS_EXPONENTIAL_BACKOFF_JITTER_FULL, 1000, 1000, 1000};
119109

120110
mqtt5Options.WithConnectOptions(packetConnect);
121-
mqtt5Options.WithBootstrap(&clientBootstrap);
111+
mqtt5Options.WithBootstrap(ApiHandle::GetOrCreateStaticDefaultClientBootstrap());
122112
mqtt5Options.WithSocketOptions(socketOptions);
123113
mqtt5Options.WithSessionBehavior(Mqtt5::ClientSessionBehaviorType::AWS_MQTT5_CSBT_REJOIN_POST_SUCCESS);
124114
mqtt5Options.WithClientExtendedValidationAndFlowControl(
@@ -797,16 +787,6 @@ static int s_setAllClientOptions(Aws::Crt::Allocator *allocator, Mqtt5ClientOpti
797787
Aws::Crt::Io::SocketOptions socketOptions;
798788
socketOptions.SetConnectTimeoutMs(3000);
799789

800-
Aws::Crt::Io::EventLoopGroup eventLoopGroup(0, allocator);
801-
ASSERT_TRUE(eventLoopGroup);
802-
803-
Aws::Crt::Io::DefaultHostResolver defaultHostResolver(eventLoopGroup, 8, 30, allocator);
804-
ASSERT_TRUE(defaultHostResolver);
805-
806-
Aws::Crt::Io::ClientBootstrap clientBootstrap(eventLoopGroup, defaultHostResolver, allocator);
807-
ASSERT_TRUE(allocator);
808-
clientBootstrap.EnableBlockingShutdown();
809-
810790
// Setup will
811791
const Aws::Crt::String TEST_TOPIC =
812792
"test/MQTT5_Binding_CPP/s_TestMqtt5DirectConnectionFull" + Aws::Crt::UUID().ToString();
@@ -833,7 +813,7 @@ static int s_setAllClientOptions(Aws::Crt::Allocator *allocator, Mqtt5ClientOpti
833813
Mqtt5::JitterMode::AWS_EXPONENTIAL_BACKOFF_JITTER_FULL, 1000, 1000, 1000};
834814

835815
mqtt5Options.WithConnectOptions(packetConnect);
836-
mqtt5Options.WithBootstrap(&clientBootstrap);
816+
mqtt5Options.WithBootstrap(ApiHandle::GetOrCreateStaticDefaultClientBootstrap());
837817
mqtt5Options.WithSocketOptions(socketOptions);
838818
mqtt5Options.WithSessionBehavior(Mqtt5::ClientSessionBehaviorType::AWS_MQTT5_CSBT_REJOIN_POST_SUCCESS);
839819
mqtt5Options.WithClientExtendedValidationAndFlowControl(
@@ -2339,16 +2319,6 @@ static int s_TestMqtt5to3AdapterNewClientFull(Aws::Crt::Allocator *allocator, vo
23392319
Aws::Crt::Io::SocketOptions socketOptions;
23402320
socketOptions.SetConnectTimeoutMs(3000);
23412321

2342-
Aws::Crt::Io::EventLoopGroup eventLoopGroup(0, allocator);
2343-
ASSERT_TRUE(eventLoopGroup);
2344-
2345-
Aws::Crt::Io::DefaultHostResolver defaultHostResolver(eventLoopGroup, 8, 30, allocator);
2346-
ASSERT_TRUE(defaultHostResolver);
2347-
2348-
Aws::Crt::Io::ClientBootstrap clientBootstrap(eventLoopGroup, defaultHostResolver, allocator);
2349-
ASSERT_TRUE(allocator);
2350-
clientBootstrap.EnableBlockingShutdown();
2351-
23522322
// Setup will
23532323
const Aws::Crt::String TEST_TOPIC = "test/MQTT5_Binding_CPP/s_TestMqtt5NewClientFull";
23542324
ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test");
@@ -2374,7 +2344,7 @@ static int s_TestMqtt5to3AdapterNewClientFull(Aws::Crt::Allocator *allocator, vo
23742344
Mqtt5::JitterMode::AWS_EXPONENTIAL_BACKOFF_JITTER_FULL, 1000, 1000, 1000};
23752345

23762346
mqtt5Options.WithConnectOptions(packetConnect);
2377-
mqtt5Options.WithBootstrap(&clientBootstrap);
2347+
mqtt5Options.WithBootstrap(ApiHandle::GetOrCreateStaticDefaultClientBootstrap());
23782348
mqtt5Options.WithSocketOptions(socketOptions);
23792349
mqtt5Options.WithSessionBehavior(Mqtt5::ClientSessionBehaviorType::AWS_MQTT5_CSBT_REJOIN_POST_SUCCESS);
23802350
mqtt5Options.WithClientExtendedValidationAndFlowControl(

0 commit comments

Comments
 (0)