default metrics to true

Author: xiazhvera

include/aws/crt/mqtt/Mqtt5Packets.h

@@ -1171,7 +1171,7 @@ namespace Aws
                  */
                 Crt::Vector<UserProperty> m_userProperties;
 
-                bool m_enableMetrics;
+                bool m_enableMetrics = true;
                 Mqtt::IoTDeviceSDKMetrics m_sdkMetrics;
 
                 ///////////////////////////////////////////////////////////////////////////

include/aws/crt/mqtt/MqttClient.h

@@ -85,6 +85,7 @@ namespace Aws
                  * @param socketOptions socket options to use when establishing the connection
                  * @param tlsContext tls context to use with the connection
                  * @param useWebsocket should the connection use websockets or should it use direct mqtt?
+                 * @param enableMetrics enable AWS IoT metrics collection
                  *
                  * @return a new connection object.  Connect() will still need to be called after all further
                  * configuration is finished.
@@ -104,6 +105,7 @@ namespace Aws
                  * @param port port to connect to
                  * @param socketOptions socket options to use when establishing the connection
                  * @param useWebsocket should the connection use websockets or should it use direct mqtt?
+                 * @param enableMetrics enable AWS IoT metrics collection
                  *
                  * @return a new connection object.  Connect() will still need to be called after all further
                  * configuration is finished.

include/aws/crt/mqtt/private/MqttConnectionCore.h

@@ -388,7 +388,7 @@ namespace Aws
                 bool m_useTls;
                 bool m_useWebsocket;
                 MqttConnectionOperationStatistics m_operationStatistics;
-                bool m_enableMetrics;
+                bool m_enableMetrics = true;
                 IoTDeviceSDKMetrics m_sdkMetrics;
                 Allocator *m_allocator;
 

source/mqtt/Mqtt5Packets.cpp

@@ -355,8 +355,15 @@ namespace Aws
                 s_AllocateUnderlyingUserProperties(m_userPropertiesStorage, m_userProperties, m_allocator);
                 raw_options.user_properties = m_userPropertiesStorage;
                 raw_options.user_property_count = m_userProperties.size();
-                m_sdkMetrics.initializeRawOptions(m_metricsStorage);
-                raw_options.metrics = &m_metricsStorage;
+                if (m_enableMetrics)
+                {
+                    m_sdkMetrics.initializeRawOptions(m_metricsStorage);
+                    raw_options.metrics = &m_metricsStorage;
+                }
+                else
+                {
+                    raw_options.metrics = nullptr;
+                }
 
                 return true;
             }