minor fixes

Author: DmitriyMusatkin

include/aws/crt/checksum/XXHash.h

@@ -44,11 +44,10 @@ namespace Aws
             class AWS_CRT_CPP_API XXHash final
             {
               public:
-                ~XXHash();
                 XXHash(const XXHash &) = delete;
                 XXHash &operator=(const XXHash &) = delete;
-                XXHash(XXHash &&toMove);
-                XXHash &operator=(XXHash &&toMove);
+                XXHash(XXHash &&toMove) noexcept = default;
+                XXHash &operator=(XXHash &&toMove) noexcept = default;
 
                 /**
                  * Returns the value of the last aws error encountered by operations on this instance.
@@ -87,7 +86,7 @@ namespace Aws
                 XXHash(aws_xxhash *hash) noexcept;
                 XXHash() = delete;
 
-                aws_xxhash *m_hash;
+                ScopedResource<struct aws_xxhash> m_hash;
                 int m_lastError;
             };
         } // namespace Checksum

source/checksum/XXHash.cpp

@@ -26,38 +26,14 @@ namespace Aws
                 return aws_xxhash3_128_compute(seed, input, &output) == AWS_OP_SUCCESS;
             }
 
-            XXHash::XXHash(aws_xxhash *hash) noexcept : m_hash(hash), m_lastError(0)
+            XXHash::XXHash(aws_xxhash *hash) noexcept : m_hash(hash, aws_xxhash_destroy), m_lastError(0)
             {
-                if (!hash)
+                if (hash == nullptr)
                 {
-                    m_lastError = aws_last_error();
-                }
-            }
-
-            XXHash::~XXHash()
-            {
-                if (m_hash)
-                {
-                    aws_xxhash_destroy(m_hash);
-                    m_hash = nullptr;
+                    m_lastError = Crt::LastError();
                 }
             }
 
-            XXHash::XXHash(XXHash &&toMove) : m_hash(toMove.m_hash), m_lastError(toMove.m_lastError)
-            {
-                toMove.m_hash = nullptr;
-            }
-
-            XXHash &XXHash::operator=(XXHash &&toMove)
-            {
-                if (&toMove != this)
-                {
-                    *this = XXHash(std::move(toMove));
-                }
-
-                return *this;
-            }
-
             XXHash XXHash::CreateXXHash64(uint64_t seed, Allocator *allocator) noexcept
             {
                 return XXHash(aws_xxhash64_new(allocator, seed));

tests/CMakeLists.txt

@@ -63,6 +63,7 @@ add_test_case(JsonExplicitNull)
 add_test_case(JsonBoolTest)
 add_test_case(JsonMoveTest)
 add_test_case(SHA256ResourceSafety)
+add_test_case(SHA512ResourceSafety)
 add_test_case(MD5ResourceSafety)
 add_test_case(SHA1ResourceSafety)
 add_test_case(SHA256HMACResourceSafety)
@@ -322,6 +323,14 @@ if (NOT BYO_CRYPTO)
     add_test_case(HKDFPiping)
 endif()
 
+add_test_case(CRC32Piping);
+add_test_case(CRC32CPiping);
+add_test_case(CRC64NVMEPiping);
+
+add_test_case(XXHash64Piping);
+add_test_case(XXHash3_64Piping);
+add_test_case(XXHash3_128Piping);
+
 generate_cpp_test_driver(${TEST_BINARY_NAME})
 
 aws_add_sanitizers(${TEST_BINARY_NAME})