aws-crt-cpp is not building on Amazonlinux

[AbhishekPuranam]

Describe the bug

aws-crt-cpp latest commit is not building successfully on Amazon linux in v0.29.9

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

It should build successfully on public.ecr.aws/amazonlinux/amazonlinux:latest

Current Behavior

Getting below error:

731.0 /tmp/aws-crt-cpp/source/iot/MqttRequestResponseClient.cpp: In static member function 'static std::shared_ptrAws::Iot::RequestResponse::IStreamingOperation Aws::Iot::RequestResponse::StreamingOperation::Create(Aws::Crt::Allocator*, const Aws::Iot::RequestResponse::StreamingOperationOptionsInternal&, aws_mqtt_request_response_client*)':
731.0 /tmp/aws-crt-cpp/source/iot/MqttRequestResponseClient.cpp:249:86: error: invalid conversion from 'void ()(aws_byte_cursor, void)' to 'void ()(aws_byte_cursor, aws_byte_cursor, void)' [-fpermissive]
731.0 249 | streamingOptions.incoming_publish_callback = StreamingOperationImpl::OnIncomingPublishCallback;
731.0 | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
731.0 | |
731.0 | void ()(aws_byte_cursor, void)

Reproduction Steps

Install aws-crt-cpp on public.ecr.aws/amazonlinux/amazonlinux:latest using below commands

aws-crt-cpp : PKG=aws-crt-cpp
aws-crt-cpp : URL=https://github.com/awslabs/aws-crt-cpp.git/
aws-crt-cpp : aws-c-common aws-c-io aws-c-mqtt aws-c-auth aws-c-http aws-checksums aws-c-event-stream aws-c-s3 install_dir
rm -rf build-${PKG} && mkdir -p build-${PKG}
rm -rf ${PKG} && git clone ${URL} ${PKG}
cd ${PKG}
cd build-${PKG} && cmake -DBUILD_DEPS=OFF ${CMAKE_FLAGS} ../${PKG}
make -C build-${PKG} install

Possible Solution

No response

Additional Information/Context

No response

aws-crt-cpp version used

v0.29.9

Compiler and version used

v0.29.9

Operating System and version

amazonlinux:latest

[AbhishekPuranam]

Compiling with cmake 3.22.2-1.amzn2023.0.4

[bretambrose]

The CRT is a transitive closure of a set of C libraries. There are no guarantees of correctness unless you use a CRT commit that snapshots all of the dependencies (as submodules).

In your repro steps

1. You don't initialize the submodules so they're empty
2. You use BUILD_DEPS=OFF which pulls the C libraries from an external install

The C++ and C pieces are badly out of sync.

To fix this:

1. clone the CRT with submodules: git clone --recursive ${URL}
2. Remove -DBUILD_DEPS=OFF from your cmake command line

[AbhishekPuranam]

Thanks a lot