Completable Futures get and remove refs from its parent manager

Author: sbSteveK

src/main/java/software/amazon/awssdk/crt/CrtResource.java

@@ -238,6 +238,9 @@ public long getNativeHandle() {
      */
     public void addRef() {
         refCount.incrementAndGet();
+        if (debugNativeObjects) {
+            Log.log(ResourceLogLevel, Log.LogSubject.JavaCrtResource, String.format("Instance of class %s(%d) is adding a reference", this.getClass().getCanonicalName(), id));
+        }
     }
 
     /**

src/main/java/software/amazon/awssdk/crt/http/HttpClientConnectionManager.java

@@ -162,6 +162,10 @@ public CompletableFuture<HttpClientConnection> acquireConnection() {
         }
 
         CompletableFuture<HttpClientConnection> returnedFuture = new CompletableFuture<>();
+        /* Futures need to add a ref so the HttpClientConnectionManager doesn't clean up from underneath the Future. */
+        this.addRef();
+        /* This insures that whether a CompletableFuture completes or throws an exception, we remove the ref it added. */
+        returnedFuture.whenComplete((conn, ex) -> decRef());
         httpClientConnectionManagerAcquireConnection(this.getNativeHandle(), returnedFuture);
         return returnedFuture;
     }