update error type

Author: Krish

src/main/java/software/amazon/awssdk/crt/CRT.java

@@ -495,7 +495,7 @@ private static native void awsCrtInit(int memoryTracingLevel, boolean debugWait,
      *                  function call
      * @return The corresponding SdkErrorType for the error code
      */
-    public static native ErrorType awsGetSdkErrorType(int errorCode);
+    public static native ErrorType awsGetErrorType(int errorCode);
 
     /**
      * @return The number of bytes allocated in native resources. If

src/main/java/software/amazon/awssdk/crt/ErrorType.java

@@ -1,10 +1,17 @@
 package software.amazon.awssdk.crt;
 
 public enum ErrorType {
-    SUCCESS,
-    THROTTLING,
-    SERVER_ERROR,
-    CONFIGURED_TIMEOUT,
-    IO,
-    OTHER
+    SUCCESS("Success"),
+    OTHER("Other"),
+    THROTTLING("Throttling"),
+    SERVER_ERROR("ServerError"),
+    CONFIGURED_TIMEOUT("ConfiguredTimeout"),
+    IO("IO"),
+    ;
+
+    public final String name;
+
+    ErrorType(String name) {
+        this.name = name;
+    }
 }

src/main/java/software/amazon/awssdk/crt/s3/S3RequestMetrics.java

@@ -92,7 +92,7 @@ public long getBackoffDelayDurationNs() {
     }
 
     public ErrorType getErrorType() {
-        return CRT.awsGetSdkErrorType(this.errorCode);
+        return CRT.awsGetErrorType(this.errorCode);
     }
 
     public long getServiceCallDurationNs() {

src/native/crt.c

@@ -619,20 +619,20 @@ static jobject s_get_error_type_enum(JNIEnv *env, int error_code) {
             ordinal = 0; // SUCCESS
             break;
         case AWS_ERROR_S3_SLOW_DOWN:
-            ordinal = 1; // THROTTLING
+            ordinal = 2; // THROTTLING
             break;
         case AWS_ERROR_S3_INTERNAL_ERROR:
         case AWS_ERROR_S3_INVALID_RESPONSE_STATUS:
         case AWS_ERROR_S3_REQUEST_TIME_TOO_SKEWED:
         case AWS_ERROR_S3_NON_RECOVERABLE_ASYNC_ERROR:
-            ordinal = 2; // SERVER_ERROR
+            ordinal = 3; // SERVER_ERROR
             break;
         case AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT:
         case AWS_ERROR_HTTP_CONNECTION_MANAGER_ACQUISITION_TIMEOUT:
         case AWS_ERROR_S3_REQUEST_TIMEOUT:
         case AWS_IO_SOCKET_TIMEOUT:
         case AWS_IO_TLS_NEGOTIATION_TIMEOUT:
-            ordinal = 3; // CONFIGURED_TIMEOUT
+            ordinal = 4; // CONFIGURED_TIMEOUT
             break;
         case AWS_ERROR_HTTP_CONNECTION_CLOSED:
         case AWS_ERROR_HTTP_CONNECTION_MANAGER_SHUTTING_DOWN:
@@ -641,10 +641,10 @@ static jobject s_get_error_type_enum(JNIEnv *env, int error_code) {
         case AWS_ERROR_HTTP_SERVER_CLOSED:
         case AWS_ERROR_HTTP_GOAWAY_RECEIVED:
         case AWS_ERROR_HTTP_RST_STREAM_RECEIVED:
-            ordinal = 4; // IO
+            ordinal = 5; // IO
             break;
         default:
-            ordinal = 5; // OTHER
+            ordinal = 1; // OTHER
             break;
     }
 
@@ -749,7 +749,7 @@ jstring JNICALL Java_software_amazon_awssdk_crt_CRT_awsErrorName(JNIEnv *env, jc
 
 JNIEXPORT
 jobject JNICALL
-    Java_software_amazon_awssdk_crt_CRT_awsGetSdkErrorType(JNIEnv *env, jclass jni_crt_class, jint error_code) {
+    Java_software_amazon_awssdk_crt_CRT_awsGetErrorType(JNIEnv *env, jclass jni_crt_class, jint error_code) {
     (void)jni_crt_class;
     jobject error_type = s_get_error_type_enum(env, error_code);
     return error_type;