Skip to content

Commit ff52d41

Browse files
committed
no need to clear an exception on our internal functions
1 parent a7d5acc commit ff52d41

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

src/native/java_class_ids.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2248,7 +2248,7 @@ static void s_cache_mqtt5_publish_return(JNIEnv *env) {
22482248
AWS_FATAL_ASSERT(cls);
22492249
mqtt5_publish_return_properties.return_class = (*env)->NewGlobalRef(env, cls);
22502250
AWS_FATAL_ASSERT(mqtt5_publish_return_properties.return_class);
2251-
/* Constructor: PublishReturn(PublishPacket, long) */
2251+
// Functions
22522252
mqtt5_publish_return_properties.return_constructor_id = (*env)->GetMethodID(
22532253
env,
22542254
mqtt5_publish_return_properties.return_class,

src/native/mqtt5_client.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -627,12 +627,10 @@ static void s_aws_mqtt5_client_java_publish_received(
627627
/* Invalidate the PublishReturn to prevent post-callback use */
628628
(*env)->CallVoidMethod(
629629
env, publish_packet_return_data, mqtt5_publish_return_properties.return_invalidate_after_callback_id);
630-
aws_jni_check_and_clear_exception(env); /* To hide JNI warning */
631630

632631
/* Check whether the user called acquirePublishAcknowledgementControl() during the callback */
633632
jboolean user_acquired_control = (*env)->CallBooleanMethod(
634633
env, publish_packet_return_data, mqtt5_publish_return_properties.return_was_control_acquired_id);
635-
aws_jni_check_and_clear_exception(env); /* To hide JNI warning */
636634

637635
if (!user_acquired_control) {
638636
/* User did NOT call acquirePublishAcknowledgementControl(); auto-invoke the PUBACK */

0 commit comments

Comments
 (0)