Skip to content

Commit 657a47a

Browse files
authored
update the default behaviors on the fio options (#689)
1 parent 8aff6bb commit 657a47a

6 files changed

Lines changed: 16 additions & 10 deletions

File tree

.builder/actions/aws_crt_python.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,13 @@ def run(self, env):
3939
# "--failfast" because, given how our leak-detection in tests currently works,
4040
# once one test fails all the rest usually fail too.
4141
[self.python, '-m', 'unittest', 'discover', '--verbose', '--failfast'],
42-
# http_client_test.py launches external processes using the extra args
43-
[self.python, 'crt/aws-c-http/integration-testing/http_client_test.py',
44-
self.python, 'elasticurl.py'],
42+
# postman-echo.com in now requires TLS1.3,
43+
# but our Mac implementation doesn't support TLS1.3 yet.
44+
# The work has been planned to Dec. 2025 to support TLS1.3,
45+
# so disable the test for now. And reenable it afterward
46+
# # http_client_test.py launches external processes using the extra args
47+
# [self.python, 'crt/aws-c-http/integration-testing/http_client_test.py',
48+
# self.python, 'elasticurl.py'],
4549
]
4650

4751
return Builder.Script(actions, name='aws-crt-python')

awscrt/s3.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ class S3ChecksumConfig:
145145
@dataclass
146146
class S3FileIoOptions:
147147
"""
148+
WARNING: experimental/unstable, the default behavior is subjected to change in the future.
148149
Controls how client performance file I/O operations.
149150
Only applies to the file based workload.
150151
Notes: only applies when `send_filepath` is set from the request.
@@ -153,19 +154,20 @@ class S3FileIoOptions:
153154
should_stream: bool = False
154155
"""
155156
Skip buffering the part in memory before sending the request.
156-
If set, set the `disk_throughput` to be reasonable align with the available disk throughput.
157-
Otherwise, the transfer may fail with connection starvation.
157+
158+
Default to false on small objects, and true when the object size exceed a certain threshold.
158159
"""
159160

160161
disk_throughput_gbps: (Optional[float]) = 0.0
161162
"""
162163
The estimated disk throughput. Only be applied when `streaming_upload` is true.
163164
in gigabits per second (Gbps).
164-
When doing upload with streaming, it's important to set the disk throughput to prevent the connection starvation.
165165
166166
Notes: There are possibilities that cannot reach the all available disk throughput:
167167
1. Disk is busy with other applications
168168
2. OS Cache may cap the throughput, use `direct_io` to get around this.
169+
170+
Default to `throughput_target_gbps`.
169171
"""
170172

171173
direct_io: bool = False

crt/aws-lc

crt/s2n

Submodule s2n updated from 792d366 to 30f40f2

0 commit comments

Comments
 (0)