update 8

Author: Dan Xie

src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/china-support/china-forward-function/tests/test_handler.py

@@ -2,11 +2,13 @@
 Tests for the AWS Lambda handler that forwards events to Step Functions.
 """
 import os
+import importlib
 from unittest.mock import patch, MagicMock
 
 import pytest
 import handler
 
+# pylint: disable=redefined-outer-name,no-member,unused-argument
 
 @pytest.fixture
 def mock_env_variables(aws_settings):
@@ -40,7 +42,11 @@ def mock_boto3_session():
     # Patch boto3.session.Session to use our mock constructor
     with patch("boto3.session.Session", mock_session_constructor):
         # Yield both the session constructor and client mocks
-        yield {"session_constructor": mock_session_constructor, "session": mock_session, "client": mock_client}
+        yield {
+            "session_constructor": mock_session_constructor,
+            "session": mock_session,
+            "client": mock_client
+        }
 
 
 @pytest.fixture
@@ -58,7 +64,11 @@ class TestLambdaHandler:
     """Tests for the lambda_handler function."""
 
     def test_lambda_handler_with_organizations_event(
-        self, mock_env_variables, mock_boto3_session, mock_stepfunction, aws_settings # pylint: disable=unused-argument
+        self,
+        mock_env_variables,
+        mock_boto3_session,
+        mock_stepfunction,
+        aws_settings
     ):
         """Test handling of an AWS Organizations event."""
         region = aws_settings["region"]
@@ -86,7 +96,7 @@ def test_lambda_handler_with_organizations_event(
         )
 
     def test_lambda_handler_with_non_organizations_event(
-        self, mock_env_variables, mock_boto3_session, mock_stepfunction # pylint: disable=unused-argument
+        self, mock_env_variables, mock_boto3_session, mock_stepfunction
     ):
         """Test handling of a non-AWS Organizations event."""
         event = {
@@ -100,7 +110,12 @@ def test_lambda_handler_with_non_organizations_event(
         handler.Stepfunction.assert_not_called()
         mock_stepfunction.invoke_sfn_execution.assert_not_called()
 
-    def test_lambda_handler_with_missing_source(self, mock_env_variables, mock_boto3_session, mock_stepfunction): # pylint: disable=unused-argument
+    def test_lambda_handler_with_missing_source(
+        self,
+        mock_env_variables,
+        mock_boto3_session,
+        mock_stepfunction
+    ):
         """Test handling of an event missing the source field."""
         event = {"detail-type": "Some Event", "detail": {}}
 
@@ -118,8 +133,5 @@ def test_sfn_name_extraction(aws_settings):
     partition = aws_settings["partition"]
     sfn_arn = f"arn:{partition}:states:{region}:123456789012:stateMachine:{sfn_name}"
     with patch.dict(os.environ, {"SFN_ARN": sfn_arn}):
-        # Re-import to get the updated SFN_ARN value
-        import importlib
-
         importlib.reload(handler)
         assert handler.sfn_name == sfn_name

src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/china-support/tests/test_create_s3_cn.py

@@ -1,13 +1,12 @@
 """
 s3 bucket creation script
 """
-
-import pytest
 from unittest.mock import patch, MagicMock
 
-# Import the module to test
+import pytest
 import create_s3_cn
 
+# pylint: disable=redefined-outer-name,no-member,unused-argument
 
 @pytest.fixture
 def mock_env_vars():
@@ -46,7 +45,7 @@ def mock_logger():
         yield mock_logger
 
 
-def test_create_s3_bucket_china(mock_env_vars, mock_cloudformation, mock_logger): # pylint: disable=unused-argument
+def test_create_s3_bucket_china(mock_env_vars, mock_cloudformation, mock_logger):
     """Test creating an S3 bucket in China region."""
     # Arrange
     bucket_name = "adf-china-bootstrap-cn-northwest-1-123456789012"
@@ -81,7 +80,7 @@ def test_create_s3_bucket_china(mock_env_vars, mock_cloudformation, mock_logger)
     mock_logger.info.assert_called_with("Deploy S3 bucket %s...", bucket_name)
 
 
-def test_create_s3_bucket_exception(mock_env_vars, mock_cloudformation, mock_logger): # pylint: disable=unused-argument
+def test_create_s3_bucket_exception(mock_env_vars, mock_cloudformation, mock_logger):
     """Test exception handling when creating an S3 bucket fails."""
     # Arrange
     bucket_name = "adf-china-bootstrap-cn-northwest-1-123456789012"
@@ -96,7 +95,7 @@ def test_create_s3_bucket_exception(mock_env_vars, mock_cloudformation, mock_log
     assert "Failed to process _create_s3_bucket" in mock_logger.error.call_args[0][0]
 
 
-def test_main_function(mock_env_vars, monkeypatch): # pylint: disable=unused-argument
+def test_main_function(mock_env_vars, monkeypatch):
     """Test the main function calls _create_s3_bucket with correct bucket name."""
     # Arrange
     mock_create_bucket = MagicMock()
@@ -112,7 +111,7 @@ def test_main_function(mock_env_vars, monkeypatch): # pylint: disable=unused-arg
     mock_create_bucket.assert_called_once_with(expected_bucket_name)
 
 
-def test_cloudformation_template_path(mock_env_vars, mock_cloudformation): # pylint: disable=unused-argument
+def test_cloudformation_template_path(mock_env_vars, mock_cloudformation):
     """Test the CloudFormation template path is correct."""
     # Arrange
     bucket_name = "test-bucket"