Skip to content

Commit 915e716

Browse files
authored
Fix updating old global-iam stacks in the deployment account (#711)
**Why?** With PR #568, the policy names in the `adf-bootstrap/deployment/example-global-iam.yml` file were updated to ensure that they are unique. However, if the `example-global-iam.yml` was not updated recently, then copied/renamed to `global-iam.yml` it would overwrite, and or delete policies that were created by the `global.yml` stack instead. This creates an issue that is hard to debug unfortunately. **What?** This proposed change will introduce the ADF managed policy as defined in the `global.yml` stack of the deployment account. This way the policies are (re)created correctly.
1 parent 8ad242d commit 915e716

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/global.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ Resources:
549549
CloudFormationDeploymentPolicy:
550550
Type: AWS::IAM::Policy
551551
Properties:
552-
PolicyName: "adf-cloudformation-deployment-role-policy"
552+
PolicyName: "adf-cloudformation-deployment-role-policy-kms"
553553
PolicyDocument:
554554
Version: "2012-10-17"
555555
Statement:

src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/enable_cross_account_access.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"adf-codepipeline-role-policy-kms",
4747
],
4848
"adf-cloudformation-deployment-role": [
49-
"adf-cloudformation-deployment-role-policy",
49+
"adf-cloudformation-deployment-role-policy-kms",
5050
],
5151
"adf-cloudformation-role": [
5252
"adf-cloudformation-role-policy",

0 commit comments

Comments
 (0)