Skip to content

Commit a64c2fa

Browse files
danxie1999Dan Xie
authored and
Dan Xie
committed
fix the china extra stack deletion issue.
1 parent ba03038 commit a64c2fa

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/china-support/create_s3_cn.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
REGION_DEFAULT = os.environ["AWS_REGION"]
1515
MANAGEMENT_ACCOUNT_ID = os.environ["MANAGEMENT_ACCOUNT_ID"]
1616
LOGGER = configure_logger(__name__)
17-
17+
ADF_GLOBAL_BOOTSTRAP_CHINA_BUCKET_STACK_NAME = "adf-regional-base-china-bucket"
1818

1919
def _create_s3_bucket(bucket_name):
2020
try:
2121
LOGGER.info("Deploy S3 bucket %s...", bucket_name)
2222
extra_deploy_region = "cn-northwest-1"
2323
template_path = "adf-build/china-support/cn_northwest_bucket.yml"
24-
stack_name = "adf-regional-base-china-bucket"
24+
stack_name = ADF_GLOBAL_BOOTSTRAP_CHINA_BUCKET_STACK_NAME
2525
parameters = [
2626
{
2727
"ParameterKey": "BucketName",

src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
from errors import InvalidTemplateError, GenericAccountConfigureError
1717
from logger import configure_logger
1818
from paginator import paginator
19+
from partition import get_partition
20+
1921

2022
LOGGER = configure_logger(__name__)
2123
STACK_TERMINATION_PROTECTION = os.environ.get('TERMINATION_PROTECTION', False)
@@ -29,7 +31,8 @@
2931
CFN_UNACCEPTED_CHARS = re.compile(r"[^-a-zA-Z0-9]")
3032
ADF_GLOBAL_IAM_STACK_NAME = 'adf-global-base-iam'
3133
ADF_GLOBAL_BOOTSTRAP_STACK_NAME = 'adf-global-base-bootstrap'
32-
34+
ADF_GLOBAL_BOOTSTRAP_CHINA_BUCKET_STACK_NAME = "adf-regional-base-china-bucket"
35+
ADF_GLOBAL_BOOTSTRAP_CHINA_EXTRA_STACK_NAME = "adf-regional-base-china-extra"
3336

3437
class StackProperties:
3538
clean_stack_status = [
@@ -148,6 +151,10 @@ def _get_valid_stack_names(self):
148151
valid_stack_names.append(ADF_GLOBAL_IAM_STACK_NAME)
149152
valid_stack_names.append(ADF_GLOBAL_BOOTSTRAP_STACK_NAME)
150153

154+
if self.partition == "aws-cn":
155+
valid_stack_names.append(ADF_GLOBAL_BOOTSTRAP_CHINA_BUCKET_STACK_NAME)
156+
valid_stack_names.append(ADF_GLOBAL_BOOTSTRAP_CHINA_EXTRA_STACK_NAME)
157+
151158
return valid_stack_names
152159

153160

@@ -197,6 +204,7 @@ def __init__(
197204
if template_file_prefix else None
198205
self.template_url = template_url or self.template_url_from_template_file_prefix
199206
self.local_template_path = local_template_path
207+
self.partition = get_partition(region)
200208

201209
def validate_template(self):
202210
try:

0 commit comments

Comments
 (0)