SDK crates pull in both aws-lc-rs and ring if the default features are used

[aochagavia]

Consider the case of S3, which has the following default features:

aws-sdk-rust/sdk/s3/Cargo.toml

Line 231 in 87b9d75

default = ["sigv4a", "http-1x", "rustls", "default-https-client", "rt-tokio"]

Here, both rustls and default-https-client are enabled, which then propagate to aws-smithy-runtime:

tls-rustls = ["dep:aws-smithy-http-client", "aws-smithy-http-client?/legacy-rustls-ring", "connector-hyper-0-14-x"]
default-https-client = ["dep:aws-smithy-http-client", "aws-smithy-http-client?/rustls-aws-lc"]

In the end, you end up with both ring and aws-lc-rs in your tree! Also, you end up with two versions of hyper. Is this intentional?

It seems to me that the default should pick either rustls or default-https-client, but not both.

[landonxjames]

This is intentional and was done to maintain backwards compatibility when we migrated to the hyper-1.x ecosystem. You can find more information about that in the announcement here: #1257. We will likely remove the hyper-0.x client at some point in the future, but that will be a breaking change we will need to warn customer about before it happens.