Skip to content

Commit e0dc8ad

Browse files
added a custom timeout for Self Managed Nodegroups (#246)
1 parent d7debc1 commit e0dc8ad

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818
- buckets
1919
- added support for `nvidia device plugin` for management of GPUs on EKS clusters
2020
- added support for adding taints and labels for self managed ngs
21+
- added a custom timeout for Self Managed Nodegroups for successful signalling
2122

2223
### **Changed**
2324

data/eks_dockerimage-replication/versions/1.29.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
ami:
2-
version: 1.29.0-20240307
2+
version: 1.29.3-20240703
33
charts:
44
nvidia_device_plugin:
55
version: 0.14.5

modules/compute/eks/stack.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
import cdk_nag
1212
import yaml
13-
from aws_cdk import Aspects, CfnJson, RemovalPolicy, Stack, Tags
13+
from aws_cdk import Aspects, CfnJson, Duration, RemovalPolicy, Stack, Tags
1414
from aws_cdk import aws_aps as aps
1515
from aws_cdk import aws_autoscaling as asg
1616
from aws_cdk import aws_ec2 as ec2
@@ -368,7 +368,7 @@ def _create_self_managed_node_group(self, dep_mod, eks_cluster, ng_config, vpc_c
368368
auto_scaling_group_name=f"{dep_mod}-{ng_config.get('eks_ng_name')}",
369369
group_metrics=[asg.GroupMetrics.all()],
370370
instance_monitoring=asg.Monitoring.DETAILED,
371-
signals=asg.Signals.wait_for_all(),
371+
signals=asg.Signals.wait_for_all(timeout=Duration.minutes(10)),
372372
)
373373

374374
self_managed_nodegroup.role.add_managed_policy(

0 commit comments

Comments
 (0)