Skip to content

Commit 15e5239

Browse files
dferguson992frgud
andauthored
Updated Docs, code documentation & documentation workflow (#30)
* update eslint, mise and package to include updated node dependency, updated gitignore to allow a drafting area * Updated README to reflect mise use, added mise.toml, fixed typos in generators and added mkdocs.yaml * Test mkdocs CI flow * Fixing issue with mkdocs workflow * Added static HTML to bypass issues with CI workflow * Updated documentation, removed static HTML, added inline comments and code docs * Attempting to fix documentation builder * Simplified labeler.yml --------- Co-authored-by: Dan Ferguson <frgud@amazon.com>
1 parent e69ad12 commit 15e5239

70 files changed

Lines changed: 4565 additions & 9406 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/labeler.yml

Lines changed: 5 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,26 @@
1+
# Top 5 most useful labels for PR organization
2+
13
# Documentation changes
24
documentation:
35
- changed-files:
46
- any-glob-to-any-file: ['*.md', 'docs/**/*']
57

6-
# Generator core changes
8+
# Generator and template changes (core functionality)
79
generator:
810
- changed-files:
911
- any-glob-to-any-file: ['generators/**/*']
1012

11-
# Template changes
12-
templates:
13-
- changed-files:
14-
- any-glob-to-any-file: ['generators/app/templates/**/*']
15-
16-
# Framework-specific changes
17-
sklearn:
18-
- changed-files:
19-
- any-glob-to-any-file: ['**/sklearn/**/*', '**/*sklearn*']
20-
21-
xgboost:
22-
- changed-files:
23-
- any-glob-to-any-file: ['**/xgboost/**/*', '**/*xgboost*']
24-
25-
tensorflow:
26-
- changed-files:
27-
- any-glob-to-any-file: ['**/tensorflow/**/*', '**/*tensorflow*']
28-
29-
transformers:
30-
- changed-files:
31-
- any-glob-to-any-file: ['**/transformers/**/*', '**/*transformers*']
32-
33-
# Infrastructure changes
34-
docker:
35-
- changed-files:
36-
- any-glob-to-any-file: ['**/Dockerfile*', '**/*.dockerfile']
37-
38-
sagemaker:
39-
- changed-files:
40-
- any-glob-to-any-file: ['**/sagemaker/**/*', '**/*sagemaker*']
41-
4213
# Testing changes
4314
tests:
4415
- changed-files:
4516
- any-glob-to-any-file: ['test/**/*', '**/*.test.js', '**/*test*']
4617

47-
# CI/CD changes
18+
# CI/CD and workflow changes
4819
ci:
4920
- changed-files:
5021
- any-glob-to-any-file: ['.github/**/*']
5122

5223
# Dependencies
5324
dependencies:
5425
- changed-files:
55-
- any-glob-to-any-file: ['package*.json', 'requirements*.txt']
56-
57-
# Configuration
58-
config:
59-
- changed-files:
60-
- any-glob-to-any-file: ['.eslintrc*', '.gitignore', '*.config.*']
26+
- any-glob-to-any-file: ['package*.json', 'requirements*.txt', '**/requirements*.txt']

.github/workflows/docs.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,19 @@ jobs:
2222
- uses: actions/checkout@v4
2323

2424
- name: Setup Python
25-
uses: actions/setup-python@v4
25+
uses: actions/setup-python@v5
2626
with:
2727
python-version: '3.x'
2828

2929
- name: Install dependencies
3030
run: |
31-
pip install mkdocs mkdocs-material
31+
pip install mkdocs-material
3232
3333
- name: Build docs
34-
run: mkdocs build
34+
run: mkdocs build --strict
3535

3636
- name: Upload artifact
37-
uses: actions/upload-artifact@v4
37+
uses: actions/upload-pages-artifact@v3
3838
with:
3939
path: ./site
4040

@@ -48,4 +48,4 @@ jobs:
4848
steps:
4949
- name: Deploy to GitHub Pages
5050
id: deployment
51-
uses: actions/deploy-pages@v2
51+
uses: actions/deploy-pages@v4

.gitignore

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
.idea/
2+
.kiro/
3+
.scripts/
4+
.vscode/
25
drafts/
36
node_modules
4-
package-lock.json
7+
package-lock.json
8+
9+
# MkDocs build output
10+
site/

README.md

Lines changed: 37 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,14 @@ Amazon SageMaker Bring Your Own Container (BYOC) lets you deploy custom machine
2222
## 📋 What You Get with ml-container-creator
2323

2424
Every generated project includes:
25-
- **Ready-to-go container** with health checks and invocation endpoints
25+
- **SageMaker-compatible container** with health checks and invocation endpoints
2626
- **Local testing suite** to validate before deployment
2727
- **Sample model and training code** to illustrate the deployment
28-
- **One-click AWS deployment** scripts
28+
- **AWS deployment scripts** for ECR and SageMaker
2929
- **Multi-framework support** (sklearn, XGBoost, TensorFlow, vLLM, SGLang)
3030

31+
> **Note**: This tool generates starter code. Review and customize for your production requirements.
32+
3133
## Prerequisites
3234

3335
Before you begin, ensure you have:
@@ -151,35 +153,60 @@ See [CONTRIBUTING](./CONTRIBUTING.md#security-issue-notifications) for more info
151153

152154
This project is licensed under the Apache-2.0 License.
153155

156+
## 📚 Documentation
157+
158+
**📖 [Full Documentation Site](https://awslabs.github.io/ml-container-creator/)** - Complete guides, examples, and API reference
159+
160+
### Quick Links
161+
- 📖 **[Getting Started](./docs/getting-started.md)** - Installation and first project tutorial
162+
- 📖 **[Examples Guide](./docs/EXAMPLES.md)** - Step-by-step examples for common use cases
163+
- 🔧 **[Troubleshooting Guide](./docs/TROUBLESHOOTING.md)** - Solutions to common issues
164+
- 🎯 **[Template System](./docs/template-system.md)** - How the template system works
165+
- 🏗️ **[Architecture](./docs/architecture.md)** - Project architecture and patterns
166+
167+
### For Contributors
168+
- 🛠️ **[Adding Features](./docs/ADDING_FEATURES.md)** - Guide for adding new frameworks
169+
- 📝 **[Coding Standards](./docs/coding-standards.md)** - Code style and conventions
170+
- ☁️ **[AWS/SageMaker Guide](./docs/aws-sagemaker.md)** - Domain knowledge and best practices
171+
172+
### Examples
173+
- [Deploy a scikit-learn Model](./docs/EXAMPLES.md#example-1-deploy-a-scikit-learn-model)
174+
- [Deploy an XGBoost Model](./docs/EXAMPLES.md#example-2-deploy-an-xgboost-model)
175+
- [Deploy a TensorFlow Model](./docs/EXAMPLES.md#example-3-deploy-a-tensorflow-model)
176+
- [Deploy a Transformer Model (LLM)](./docs/EXAMPLES.md#example-4-deploy-a-transformer-model-llm)
177+
154178
## 🆘 Support & Troubleshooting
155179

156180
### Get Help
157-
- 📖 [Documentation](https://github.com/awslabs/ml-container-creator/wiki)
181+
- 📖 [Examples Guide](./docs/EXAMPLES.md) - Detailed walkthroughs
182+
- 🔧 [Troubleshooting Guide](./docs/TROUBLESHOOTING.md) - Common issues and solutions
158183
- 🐛 [Report Issues](https://github.com/awslabs/ml-container-creator/issues)
159184
- 💬 [Community Discussions](https://github.com/awslabs/ml-container-creator/discussions)
160185
- 🗺️ [Roadmap & Feature Requests](https://github.com/awslabs/ml-container-creator/projects)
161186
- 📖 [SageMaker Documentation](https://docs.aws.amazon.com/sagemaker/)
162187

163-
### Common Issues
188+
### Quick Troubleshooting
164189

165190
**Container fails to start**
166191
```bash
167192
# Check logs
168193
docker logs your-container-name
169194

170-
# Test locally first
171-
python code/serve.py
195+
# See detailed solutions
196+
# https://github.com/awslabs/ml-container-creator/blob/main/docs/TROUBLESHOOTING.md#container-wont-start
172197
```
173198

174199
**SageMaker deployment fails**
175200
```bash
176-
# Verify IAM permissions
177-
aws iam get-role --role-name SageMakerExecutionRole
201+
# Check CloudWatch logs
202+
aws logs tail /aws/sagemaker/Endpoints/your-endpoint --follow
178203

179-
# Check ECR repository exists
180-
aws ecr describe-repositories --repository-names your-project
204+
# See detailed solutions
205+
# https://github.com/awslabs/ml-container-creator/blob/main/docs/TROUBLESHOOTING.md#endpoint-creation-failed
181206
```
182207

208+
**Need more help?** Check the [full troubleshooting guide](./docs/TROUBLESHOOTING.md)
209+
183210
<div align="center">
184211
<p>Made with ❤️ by the ML community, for the ML community</p>
185212
</div>

0 commit comments

Comments
 (0)